Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-29222: Add support for 64k pages with ARM64 #141

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #140

/assign ybettan

RHEL 9 and RHCOS for 4.15 are adding support for installing a 64k pages
size ARM kernel at runtime, with the `kernelType: '64k-pages'`
attribute in the MachineConfig specification. When applied, the kernel
is switched to the `+64k` version, e.g. `5.14.0-284.41.1.el9_2.aarch64`
becomes `5.14.0-284.41.1.el9_2.aarch64+64k`.

From a Driver Toolkit perspective, the user should be able to use a
kernel version suffixed by `+64k` at build time. This is provided by
the `kernel-64k` packages.

This change adds the relevant packages to the driver toolkit image when
the architecture is `aarch64`.

Signed-off-by: Fabien Dupont <fdupont@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2024

@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: MGMT-16701

In response to this:

This is an automated cherry-pick of #140

/assign ybettan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/retitle [release-4.15] MGMT-16740: Add support for 64k pages with ARM64

@openshift-ci openshift-ci bot changed the title [release-4.15] MGMT-16701: Add support for 64k pages with ARM64 [release-4.15] MGMT-16740: Add support for 64k pages with ARM64 Feb 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 7, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Feb 7, 2024

@openshift-cherrypick-robot: This pull request references MGMT-16740 which is a valid jira issue.

In response to this:

This is an automated cherry-pick of #140

/assign ybettan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/cc @fabiendupont @cdvultur

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2024
Copy link

openshift-ci bot commented Feb 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 7, 2024
@cdvultur
Copy link

cdvultur commented Feb 7, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 7, 2024
@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/test ci/prow/e2e-aws-driver-toolkit-presubmit

Copy link

openshift-ci bot commented Feb 7, 2024

@ybettan: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test check-commits-count
  • /test e2e-aws
  • /test e2e-aws-driver-toolkit-presubmit
  • /test e2e-upgrade
  • /test image-contents
  • /test images
  • /test verify
  • /test verify-imagestream

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-aws-driver-toolkit-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/test e2e-aws-driver-toolkit-presubmit

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/retest

3 similar comments
@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/retest

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/retest

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/retest

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/override e2e-aws-driver-toolkit-presubmit

Copy link

openshift-ci bot commented Feb 7, 2024

@ybettan: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-aws-driver-toolkit-presubmit

Only the following failed contexts/checkruns were expected:

  • ci/prow/check-commits-count
  • ci/prow/e2e-aws
  • ci/prow/e2e-aws-driver-toolkit-presubmit
  • ci/prow/e2e-upgrade
  • ci/prow/image-contents
  • ci/prow/images
  • ci/prow/verify
  • ci/prow/verify-imagestream
  • pull-ci-openshift-driver-toolkit-master-check-commits-count
  • pull-ci-openshift-driver-toolkit-master-e2e-aws
  • pull-ci-openshift-driver-toolkit-master-e2e-upgrade
  • pull-ci-openshift-driver-toolkit-master-images
  • pull-ci-openshift-driver-toolkit-master-verify
  • pull-ci-openshift-driver-toolkit-release-4.10-e2e-aws-driver-toolkit-presubmit
  • pull-ci-openshift-driver-toolkit-release-4.10-image-contents
  • pull-ci-openshift-driver-toolkit-release-4.11-verify-imagestream
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override e2e-aws-driver-toolkit-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan
Copy link
Contributor

ybettan commented Feb 7, 2024

/override ci/prow/e2e-aws-driver-toolkit-presubmit

Copy link

openshift-ci bot commented Feb 7, 2024

@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-aws-driver-toolkit-presubmit

In response to this:

/override ci/prow/e2e-aws-driver-toolkit-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

openshift-ci bot commented Feb 7, 2024

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-driver-toolkit-presubmit bd878eb link true /test e2e-aws-driver-toolkit-presubmit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ybettan
Copy link
Contributor

ybettan commented Feb 8, 2024

/retitle OCPBUGS-29222: Add support for 64k pages with ARM64

@openshift-ci openshift-ci bot changed the title [release-4.15] MGMT-16740: Add support for 64k pages with ARM64 OCPBUGS-29222: Add support for 64k pages with ARM64 Feb 8, 2024
@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-29222, which is invalid:

  • expected Jira Issue OCPBUGS-29222 to depend on a bug targeting a version in 4.16.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #140

/assign ybettan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ybettan
Copy link
Contributor

ybettan commented Feb 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 8, 2024
@openshift-ci-robot
Copy link
Contributor

@ybettan: This pull request references Jira Issue OCPBUGS-29222, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29223 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29223 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (lalon@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 8, 2024
@ybettan
Copy link
Contributor

ybettan commented Feb 8, 2024

/retitle [release-4.15] OCPBUGS-29222: Add support for 64k pages with ARM64

@openshift-ci openshift-ci bot changed the title OCPBUGS-29222: Add support for 64k pages with ARM64 [release-4.15] OCPBUGS-29222: Add support for 64k pages with ARM64 Feb 8, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 7a448c2 into openshift:release-4.15 Feb 8, 2024
9 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-29222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29222 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #140

/assign ybettan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build driver-toolkit-container-v4.15.0-202402080807.p0.g7a448c2.assembly.stream.el9 for distgit driver-toolkit.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants