MCO-392: Start using rhel-coreos image rather than machine-os-content. #142
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ybettan: This pull request references MCO-392 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.16." or "openshift-4.16.", but it targets "4.15.0" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
ybettan
force-pushed
the
machine-os-content
branch
from
8351e93
to
c788a32
Compare
|
Thanks for opening this!
It's not necessary they go together. openshift/release#48526 should be able to go in alone. Once we confirm everything still works fine, and we're confident there's nothing else relying on it, then we can coordinate on flipping over again DTK, RHCOS and ART together. |
Ack. I am not sure what openshift/release#48526 really does but in DTK we are referencing to the Anyway, I will keep it on hold until we have the ART+RHCOS+DTK parts together. |
|
OK, we're looking good now. openshift/kubernetes references have been removed. |
|
/retest |
|
/override ci/prow/images |
|
@ybettan: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/hold |
|
/override ci/prow/images |
|
/lgtm |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-upgrade |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -15,7 +15,7 @@ spec: | |||
| from: | |||
| kind: DockerImage | |||
| name: example.com/image-reference-placeholder:driver-toolkit | |||
| - name: 0.0.1-snapshot-machine-os | |||
| - name: 0.0.1-snapshot-rhel-coreos | |||
There was a problem hiding this comment.
Are you sure this change is required? IIUC, machine-os is a reference to whatever image has the machine-os component name, i.e. these kinds of labels:
"io.openshift.build.version-display-names": "machine-os=CentOS Stream CoreOS",
"io.openshift.build.versions": "machine-os=416.94.202403121338-0",
And that'll correctly refer to the new rhel-coreos image once openshift/os#1457 is in.
(The previous stab at this didn't change this and IIRC I don't think we hit issues related to that in the brief period where we had flipped all the switches.)
There was a problem hiding this comment.
I think you are right. I have reverted this part.
ybettan
force-pushed
the
machine-os-content
branch
from
c788a32
to
c42ae6e
Compare
The machine-os-content is deprecated and we'd like to stop shipping it entirely in the release payload. Point the DTK imagestream to the rhel-coreos image instead. Signed-off-by: Yoni Bettan <yonibettan@gmail.com> Co-authored-by: Jonathan Lebon <jonathan@jlebon.com>
|
/lgtm |
|
/override ci/prow/e2e-aws |
|
/override ci/prow/e2e-aws-driver-toolkit-presubmit ci/prow/e2e-upgrade |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ybettan: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/e2e-aws-driver-toolkit-presubmit |
|
/override ci/prow/e2e-upgrade |
|
@ybettan: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/images |
|
/unhold |
|
@ybettan: Overrode contexts on behalf of ybettan: ci/prow/images In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
@ybettan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
|
[ART PR BUILD NOTIFIER] This PR has been included in build driver-toolkit-container-v4.16.0-202403181742.p0.g142ddc0.assembly.stream.el9 for distgit driver-toolkit. |
The machine-os-content is deprecated and we'd like to stop shipping it entirely in the release payload. Point the DTK imagestream to the rhel-coreos image instead.
Closes: #101
/cc @jlebon