Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IR-192: Add importMode and set it to PreserveOriginal to import the manifestlisted image #144

Merged
merged 1 commit into from Apr 3, 2024

Conversation

Prashanth684
Copy link
Contributor

Similar to
openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster

manifestlisted image

Similar to
openshift/cluster-samples-operator#482, we want
CVO managed imagestreams to have the importMode as preserveOriginal so
that it imports the manifestlisted image with all arches so that it
works on a multi-arch compute cluster
@Prashanth684 Prashanth684 changed the title Add importMode and set it to PreserveOriginal to import the manifestlisted image Imagestream: Add importMode and set it to PreserveOriginal to import the manifestlisted image Mar 19, 2024
@Prashanth684
Copy link
Contributor Author

/retest-required

Copy link

openshift-ci bot commented Mar 20, 2024

@Prashanth684: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Prashanth684
Copy link
Contributor Author

Prashanth684 commented Mar 21, 2024

@ybettan do we know who creates the new tag for the imagestream on upgrades? I'm wondering if this property will carryover for the new tag when we upgrade (to new rhcos version) using this template

@ybettan
Copy link
Contributor

ybettan commented Mar 31, 2024

@ybettan do we know who creates the new tag for the imagestream on upgrades? I'm wondering if this property will carryover for the new tag when we upgrade (to new rhcos version) using this template

@Prashanth684 AFAIK, the tag's snapshot in the imagestream is replaced by the oc adm release new ... code, so I will guess that new tags are added by the oc adm upgrade command.

@ybettan
Copy link
Contributor

ybettan commented Mar 31, 2024

/lgtm
@yevgeny-shnaidman unless you have some concerns, please /approve.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2024
@yevgeny-shnaidman
Copy link

/lgtm

@yevgeny-shnaidman
Copy link

/approve

Copy link

openshift-ci bot commented Mar 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Prashanth684, yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2024
@ybettan
Copy link
Contributor

ybettan commented Apr 1, 2024

@Prashanth684 There is a requirement for a jira/valid-reference label. Would you mind creating the Jira ticket and adding it to the title as <jira title>: Add importMode and set it to PreserveOriginal to import the manifestlisted image in imagestream

@ybettan
Copy link
Contributor

ybettan commented Apr 3, 2024

/retitle IR-192: Add importMode and set it to PreserveOriginal to import the manifestlisted image

@openshift-ci openshift-ci bot changed the title Imagestream: Add importMode and set it to PreserveOriginal to import the manifestlisted image IR-192: Add importMode and set it to PreserveOriginal to import the manifestlisted image Apr 3, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 3, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 3, 2024

@Prashanth684: This pull request references IR-192 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.12" instead.

In response to this:

Similar to
openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 82e9505 into openshift:master Apr 3, 2024
7 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build driver-toolkit-container-v4.16.0-202404031748.p0.g82e9505.assembly.stream.el9 for distgit driver-toolkit.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants