New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IR-192: Add importMode and set it to PreserveOriginal to import the manifestlisted image #144
Conversation
manifestlisted image Similar to openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster
PreserveOriginal
to import the manifestlisted imagePreserveOriginal
to import the manifestlisted image
/retest-required |
@Prashanth684: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@ybettan do we know who creates the new tag for the imagestream on upgrades? I'm wondering if this property will carryover for the new tag when we upgrade (to new rhcos version) using this template |
@Prashanth684 AFAIK, the tag's snapshot in the imagestream is replaced by the |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Prashanth684, yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Prashanth684 There is a requirement for a |
/retitle IR-192: Add importMode and set it to PreserveOriginal to import the manifestlisted image |
PreserveOriginal
to import the manifestlisted image
@Prashanth684: This pull request references IR-192 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.12" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build driver-toolkit-container-v4.16.0-202404031748.p0.g82e9505.assembly.stream.el9 for distgit driver-toolkit. |
Similar to
openshift/cluster-samples-operator#482, we want CVO managed imagestreams to have the importMode as preserveOriginal so that it imports the manifestlisted image with all arches so that it works on a multi-arch compute cluster