Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OKD-40: Use a default RHEL_VERSION when the build argument is not specified #148

Merged
merged 1 commit into from
May 16, 2024

Conversation

aleskandro
Copy link
Member

In OKD, we will always want to keep the "RHEL_VERSION" set by the base CentOS stream image used to build the dtk image.

In OKD, we will always want to keep the "RHEL_VERSION" set by the base CentOS stream image used to build the dtk image.
@Prashanth684
Copy link
Contributor

/test okd-scos-images

Copy link

openshift-ci bot commented May 15, 2024

@aleskandro: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684
Copy link
Contributor

/cc @ybettan

@openshift-ci openshift-ci bot requested a review from ybettan May 15, 2024 01:59
@LorbusChris
Copy link
Member

/lgtm
/assign @bthurber

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@LorbusChris
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label May 15, 2024
@Prashanth684
Copy link
Contributor

@bthurber i know you laid out your concerns here: #145 (comment) , but we still feel this will be useful for the community if they want to build and test custom modules. As for the question of support, this will be supported through the community.

@bthurber
Copy link

@bthurber i know you laid out your concerns here: #145 (comment) , but we still feel this will be useful for the community if they want to build and test custom modules. As for the question of support, this will be supported through the community.

I am OK with adding it for OKD as-long-as there aren't any support expectations around it. Of course we can provide guidance and comment as needed but we won't be doing any formal QE or e2e testing in this space.

@Prashanth684
Copy link
Contributor

@bthurber i know you laid out your concerns here: #145 (comment) , but we still feel this will be useful for the community if they want to build and test custom modules. As for the question of support, this will be supported through the community.

I am OK with adding it for OKD as-long-as there aren't any support expectations around it. Of course we can provide guidance and comment as needed but we won't be doing any formal QE or e2e testing in this space.

There is no expectation of RedHat support for OKD - so yes, that is not a problem.

@Prashanth684 Prashanth684 changed the title Use a default RHEL_VERSION when the build argument is not specified OKD-40: Use a default RHEL_VERSION when the build argument is not specified May 16, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2024

@aleskandro: This pull request references OKD-40 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

In OKD, we will always want to keep the "RHEL_VERSION" set by the base CentOS stream image used to build the dtk image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ausil
Copy link

ausil commented May 16, 2024

@bthurber i know you laid out your concerns here: #145 (comment) , but we still feel this will be useful for the community if they want to build and test custom modules. As for the question of support, this will be supported through the community.

I am OK with adding it for OKD as-long-as there aren't any support expectations around it. Of course we can provide guidance and comment as needed but we won't be doing any formal QE or e2e testing in this space.

Could you please approve it so it can be merged? This is the last thing holding up OKD being built on CentOS Stream

Copy link

@bthurber bthurber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented May 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aleskandro, bthurber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 465152a into openshift:master May 16, 2024
8 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build driver-toolkit-container-v4.16.0-202405161711.p0.g465152a.assembly.stream.el9 for distgit driver-toolkit.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants