-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OKD-40: Use a default RHEL_VERSION when the build argument is not specified #148
Conversation
In OKD, we will always want to keep the "RHEL_VERSION" set by the base CentOS stream image used to build the dtk image.
/test okd-scos-images |
@aleskandro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/cc @ybettan |
/lgtm |
/label acknowledge-critical-fixes-only |
@bthurber i know you laid out your concerns here: #145 (comment) , but we still feel this will be useful for the community if they want to build and test custom modules. As for the question of support, this will be supported through the community. |
I am OK with adding it for OKD as-long-as there aren't any support expectations around it. Of course we can provide guidance and comment as needed but we won't be doing any formal QE or e2e testing in this space. |
There is no expectation of RedHat support for OKD - so yes, that is not a problem. |
@aleskandro: This pull request references OKD-40 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Could you please approve it so it can be merged? This is the last thing holding up OKD being built on CentOS Stream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro, bthurber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build driver-toolkit-container-v4.16.0-202405161711.p0.g465152a.assembly.stream.el9 for distgit driver-toolkit. |
In OKD, we will always want to keep the "RHEL_VERSION" set by the base CentOS stream image used to build the dtk image.