Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1977972: /etc/driver-toolkit-release.json kernel version match rpm -q output #44

Merged

Conversation

dagrayvid
Copy link
Contributor

In versions of OCP where ART is specifying the kernel version as an argument to the driver-toolkit image build, the KERNEL_VERSION and RT_KERNEL_VERSION in /etc/driver-toolkit-release.json is missing the architecture at the end. Currently this is seen when comparing between DTK builds in 4.7 and 4.8

This results in unneeded inconsistencies between OCP versions, and means in some cases the kernel versions do not match with the node labels from NFD.

@openshift-ci openshift-ci bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jun 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

@dagrayvid: This pull request references Bugzilla bug 1977972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

Bug 1977972: /etc/driver-toolkit-release.json kernel version match rpm -q output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@zvonkok
Copy link
Contributor

zvonkok commented Jun 30, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@openshift-merge-robot openshift-merge-robot merged commit e832a3b into openshift:master Jun 30, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jun 30, 2021

@dagrayvid: All pull requests linked via external trackers have merged:

Bugzilla bug 1977972 has been moved to the MODIFIED state.

In response to this:

Bug 1977972: /etc/driver-toolkit-release.json kernel version match rpm -q output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@dagrayvid: new pull request created: #45

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants