Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1979738: Remove curl of extract-vmlinux #47

Merged

Conversation

dagrayvid
Copy link
Contributor

Currently, the Dockerfile tries to curl the extract-vmlinux script, which does not work in the ART build environment. This script is available as part of the kernel packages already installed in the location /usr/src/kernels/${INSTALLED_KERNEL}/scripts/extract-vmlinux, on x86 and aarch64.

In the other architectures, we can just install whichever gcc version is available by default in the ART builds.

This is needed in order for force the driver-toolkit to install the specific gcc version which was used to compile the kernel in the driver-toolkit.

@openshift-ci openshift-ci bot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jul 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2021

@dagrayvid: This pull request references Bugzilla bug 1979738, which is invalid:

  • expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1979738: Remove curl of extract-vmlinux

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jul 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dagrayvid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jmencak and kpouget July 6, 2021 21:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 6, 2021
@dagrayvid
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2021

@dagrayvid: This pull request references Bugzilla bug 1979738, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.9.0) matches configured target release for branch (4.9.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @wabouhamad

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from wabouhamad July 6, 2021 21:47
@dagrayvid
Copy link
Contributor Author

/cc @zvonkok

@openshift-ci openshift-ci bot requested a review from zvonkok July 6, 2021 21:47
@zvonkok
Copy link
Contributor

zvonkok commented Jul 6, 2021

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 6, 2021
@openshift-merge-robot openshift-merge-robot merged commit 378698e into openshift:master Jul 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 6, 2021

@dagrayvid: All pull requests linked via external trackers have merged:

Bugzilla bug 1979738 has been moved to the MODIFIED state.

In response to this:

Bug 1979738: Remove curl of extract-vmlinux

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dagrayvid
Copy link
Contributor Author

/cherry-pick release-4.8

@openshift-cherrypick-robot

@dagrayvid: new pull request created: #48

In response to this:

/cherry-pick release-4.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants