-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHCLOUD-24456: Add base URL to plugin manifest #206
RHCLOUD-24456: Add base URL to plugin manifest #206
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Using webpack-bundle-analyzer shows that import { valid as semverValid, satisfies as semverSatisfies } from 'semver';
import type { RangeOptions as SemverRangeOptions } from 'semver'; vs. import * as semver from 'semver'; has no impact on which |
11ecfe6
to
d2b18cb
Compare
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/hold Some small improvements incoming. |
/hold cancel I'll post these improvements in a follow-up PR. |
@vojtechszocs: This pull request references RHCLOUD-24456 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
baseURL
to plugin manifest, computed from webpackoutput.publicPath
optionbaseURL
should have a trailing slash as per common webpack recommendation (if not, emit a build warning)LoadedPluginInfoEntry
type - contains everything from raw manifest, minus extensions, plus fallbacks for optional properties missing in raw manifestsample-plugin/plugin-metadata.json
➡️sample-plugin/plugin-metadata.ts
for better type checking