Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHCLOUD-23026: Allow for static models to be provided to watch hooks #221

Merged

Conversation

florkbr
Copy link
Contributor

@florkbr florkbr commented May 9, 2023

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2023

@florkbr: This pull request references RHCLOUD-23026 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/RHCLOUD-23026

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2023
Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7481e17 and 2 for PR HEAD 875574a in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.31 🎉

Comparison is base (7481e17) 39.72% compared to head (d30c80b) 40.03%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   39.72%   40.03%   +0.31%     
==========================================
  Files          68       68              
  Lines        1664     1671       +7     
  Branches      356      360       +4     
==========================================
+ Hits          661      669       +8     
  Misses        968      968              
+ Partials       35       34       -1     
Impacted Files Coverage Δ
...ges/lib-utils/src/k8s/hooks/useK8sWatchResource.ts 92.85% <100.00%> (+0.35%) ⬆️
...es/lib-utils/src/k8s/hooks/useK8sWatchResources.ts 83.33% <100.00%> (+1.14%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@florkbr florkbr force-pushed the allow-apps-to-provide-models branch from 75fc22e to d30c80b Compare May 25, 2023 23:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 25, 2023

@florkbr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@karelhala karelhala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: florkbr, karelhala

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit d15240a into openshift:main May 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants