Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move generated CRDs to the OCP versioned target manifest folder #285

Closed
wants to merge 2 commits into from

Conversation

periklis
Copy link
Contributor

Motivation

Besides the elasticsearch-operator project using the operator-sdk to generate code and CRDs it doesn't clearly adhere to the operator-sdk project structure. Thus, this PR extends the Makefile to move generated CRDs to the target manifest folder.

Depends on #277

@periklis
Copy link
Contributor Author

/hold need for rebase after dependencies are meged.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: periklis
To complete the pull request process, please assign jcantrill
You can assign the PR to them by writing /assign @jcantrill in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jcantrill
Copy link
Contributor

@alanconway Doesn't your equivalent to CLO remove operator-sdk generated manifests? I think this PR is in the wrong direction

@periklis
Copy link
Contributor Author

@periklis
Copy link
Contributor Author

/hold

@openshift-ci-robot
Copy link

@periklis: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-operator 07ffdf1 link /test e2e-operator
ci/prow/cluster-logging-operator-e2e 07ffdf1 link /test cluster-logging-operator-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@periklis
Copy link
Contributor Author

periklis commented May 4, 2020

We concluded in our arch meeting to not use this approach. Thus I close this PR.

@periklis periklis closed this May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants