New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move generated CRDs to the OCP versioned target manifest folder #285
Conversation
/hold need for rebase after dependencies are meged. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: periklis The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alanconway Doesn't your equivalent to CLO remove operator-sdk generated manifests? I think this PR is in the wrong direction |
a92db74
to
cd2b6df
Compare
cd2b6df
to
07ffdf1
Compare
/hold |
@periklis: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We concluded in our arch meeting to not use this approach. Thus I close this PR. |
Motivation
Besides the elasticsearch-operator project using the operator-sdk to generate code and CRDs it doesn't clearly adhere to the operator-sdk project structure. Thus, this PR extends the Makefile to move generated CRDs to the target manifest folder.
Depends on #277