Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1834311: Fix trusted ca bundle and hash reconciliation #351

Merged
merged 1 commit into from May 13, 2020

Conversation

periklis
Copy link
Contributor

@periklis periklis commented May 11, 2020

This PR addresses several issues on reconciliation of the trusted CA-Bundle config map as well the hash annotation on the Kibana deployment.

To address:

Needs backport to: release-4.4

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 11, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1833288, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1833288: Fix trusted ca bundle and hash reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020
@periklis periklis changed the title Bug 1833288: Fix trusted ca bundle and hash reconciliation Bug 1834311: Fix trusted ca bundle and hash reconciliation May 11, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1834311, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1834311: Fix trusted ca bundle and hash reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. and removed bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. labels May 11, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1834311, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1834311: Fix trusted ca bundle and hash reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@periklis
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. labels May 11, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1834311, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label May 11, 2020
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

pkg/k8shandler/kibana/configmap.go Show resolved Hide resolved
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@periklis
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 11, 2020
@jcantrill
Copy link
Contributor

/approve

@periklis
Copy link
Contributor Author

/retest

2 similar comments
@periklis
Copy link
Contributor Author

/retest

@periklis
Copy link
Contributor Author

/retest

@ewolinetz
Copy link
Contributor

@periklis couple nits otherwise 👍

@jcantrill
Copy link
Contributor

/approve

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@periklis
Copy link
Contributor Author

/retest

@periklis
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2020
@openshift-merge-robot openshift-merge-robot merged commit da6a09b into openshift:master May 13, 2020
@openshift-ci-robot
Copy link

@periklis: All pull requests linked via external trackers have merged: openshift/cluster-logging-operator#517, openshift/elasticsearch-operator#351. Bugzilla bug 1834311 has been moved to the MODIFIED state.

In response to this:

Bug 1834311: Fix trusted ca bundle and hash reconciliation

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@periklis
Copy link
Contributor Author

/cherry-pick release-4.4

@openshift-cherrypick-robot

@periklis: #351 failed to apply on top of branch "release-4.4":

Using index info to reconstruct a base tree...
A	pkg/controller/proxyconfig/controller.go
A	pkg/controller/trustedcabundle/controller.go
A	pkg/k8shandler/kibana/configmap.go
A	pkg/k8shandler/kibana/kibana_test.go
A	pkg/k8shandler/kibana/reconciler.go
A	pkg/k8shandler/kibana/trustedcabundle.go
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): pkg/k8shandler/kibana/trustedcabundle.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/k8shandler/kibana/trustedcabundle.go left in tree.
CONFLICT (modify/delete): pkg/k8shandler/kibana/reconciler.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/k8shandler/kibana/reconciler.go left in tree.
CONFLICT (modify/delete): pkg/k8shandler/kibana/kibana_test.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/k8shandler/kibana/kibana_test.go left in tree.
CONFLICT (modify/delete): pkg/k8shandler/kibana/configmap.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/k8shandler/kibana/configmap.go left in tree.
CONFLICT (modify/delete): pkg/controller/trustedcabundle/controller.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/controller/trustedcabundle/controller.go left in tree.
CONFLICT (modify/delete): pkg/controller/proxyconfig/controller.go deleted in HEAD and modified in Bug 1834311: Fix trusted ca bundle and hash reconciliation. Version Bug 1834311: Fix trusted ca bundle and hash reconciliation of pkg/controller/proxyconfig/controller.go left in tree.
error: Failed to merge in the changes.
Patch failed at 0001 Bug 1834311: Fix trusted ca bundle and hash reconciliation

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport/4.4 bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants