Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1835903: Move elasticsearch api client to a separate package #356

Merged
merged 1 commit into from May 18, 2020
Merged

Bug 1835903: Move elasticsearch api client to a separate package #356

merged 1 commit into from May 18, 2020

Conversation

periklis
Copy link
Contributor

@periklis periklis commented May 15, 2020 •
edited

This PR fleshes the elasticsearch api client from the k8shandler package to a separate package to enable re-usage in kibana reconciliation.

It is a prerequisite to fix: https://bugzilla.redhat.com/show_bug.cgi?id=1835903

Depends on: #355

Note for reviewers: The PR is kept for in separate commits to enable easier reviewing and merging easy for work from depending work. It will be squashed after passing review.

@periklis periklis mentioned this pull request May 15, 2020
Merged
@periklis
Copy link
Contributor Author

/hold for review @ewolinetz

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 15, 2020
@periklis periklis force-pushed the es-api-package branch 3 times, most recently from f7fd622 to 9ac4fd5 Compare May 15, 2020 16:54
@periklis periklis changed the title Move elasticsearch api client to a separate package Bug 1835903: Move elasticsearch api client to a separate package May 15, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 15, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1835903, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1835903: Move elasticsearch api client to a separate package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 15, 2020
@periklis
Copy link
Contributor Author

/retest

@jcantrill
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2020
@periklis
Copy link
Contributor Author

/retest

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ewolinetz,jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@ewolinetz ewolinetz mentioned this pull request May 18, 2020
Merged
@periklis
Copy link
Contributor Author

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 18, 2020
@periklis
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit deecfaa into openshift:master May 18, 2020
@openshift-ci-robot
Copy link

@periklis: Some pull requests linked via external trackers have merged: openshift/elasticsearch-operator#356. The following pull requests linked via external trackers have not merged:

In response to this:

Bug 1835903: Move elasticsearch api client to a separate package

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

@vimalk78 vimalk78 Awaiting requested review from vimalk78

Assignees

@ewolinetz ewolinetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@periklis @openshift-ci-robot @jcantrill @ewolinetz @openshift-bot @openshift-merge-robot