-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test #474
[release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test #474
Conversation
@openshift-cherrypick-robot: Bugzilla bug 1874081 has been cloned as Bugzilla bug 1874352. Retitling PR to link against new bug. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1874352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@igor-karpukhin: This pull request references Bugzilla bug 1874352, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@igor-karpukhin: This pull request references Bugzilla bug 1874352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ewolinetz, lukas-vlcek, openshift-cherrypick-robot, periklis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
(patch manager) @igor-karpukhin I'm inclined to approve this, but where is the CI job that shows this test is currently failing? |
@markmc there is no CI job that shows that test is failing. CI job that runs this specific upgrade test will be updated after merging this PR |
thanks; would be useful to include that sort of info (e.g. which CI job exactly?) in the commit message, PR, or even bz |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1874352 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@markmc ok, sorry. Here is the PR that adds this test for the |
This is an automated cherry-pick of #472
/assign igor-karpukhin