Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test #474

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #472

/assign igor-karpukhin

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1874081 has been cloned as Bugzilla bug 1874352. Retitling PR to link against new bug.
/retitle [release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test

In response to this:

[release-4.5] Bug 1874081: Fixed 4.4->4.5 upgrade test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.5] Bug 1874081: Fixed 4.4->4.5 upgrade test [release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test Sep 1, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1874352, which is invalid:

  • expected dependent Bugzilla bug 1874081 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

[release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 1, 2020
@igor-karpukhin
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@igor-karpukhin: This pull request references Bugzilla bug 1874352, which is invalid:

  • expected dependent Bugzilla bug 1874081 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (NOTABUG) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@igor-karpukhin
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 7, 2020
@openshift-ci-robot
Copy link

@igor-karpukhin: This pull request references Bugzilla bug 1874352, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1874081 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1874081 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 7, 2020
Copy link
Contributor

@lukas-vlcek lukas-vlcek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 7, 2020
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewolinetz
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, lukas-vlcek, openshift-cherrypick-robot, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2020
@markmc
Copy link

markmc commented Sep 17, 2020

(patch manager)

@igor-karpukhin I'm inclined to approve this, but where is the CI job that shows this test is currently failing?

@markmc markmc added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Sep 17, 2020
@igor-karpukhin
Copy link
Contributor

@markmc there is no CI job that shows that test is failing. CI job that runs this specific upgrade test will be updated after merging this PR

@markmc
Copy link

markmc commented Sep 18, 2020

@markmc there is no CI job that shows that test is failing. CI job that runs this specific upgrade test will be updated after merging this PR

thanks; would be useful to include that sort of info (e.g. which CI job exactly?) in the commit message, PR, or even bz

@markmc markmc added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. labels Sep 18, 2020
@openshift-merge-robot openshift-merge-robot merged commit cca1371 into openshift:release-4.5 Sep 18, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1874352 has been moved to the MODIFIED state.

In response to this:

[release-4.5] Bug 1874352: Fixed 4.4->4.5 upgrade test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@igor-karpukhin
Copy link
Contributor

@markmc ok, sorry. Here is the PR that adds this test for the release-4.5: openshift/release#10014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants