Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1883719: Bulk statistics are recorded under index threadpool #511

Merged
merged 1 commit into from Oct 2, 2020

Conversation

lukas-vlcek
Copy link
Contributor

@lukas-vlcek lukas-vlcek commented Oct 2, 2020

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Oct 2, 2020
@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883719: Bulk statistics are recorded under index threadpool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883719: Bulk statistics are recorded under index threadpool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lukas-vlcek
Copy link
Contributor Author

Heads up @mburke5678 I think we have documented individual alerts for Elasticsearch somewhere. If this PR gets merged we will need to update ElasticsearchBulkRequestsRejectionJumps to ElasticsearchIndexingRequestsRejectionJumps for relevant docs version.

@openshift-ci-robot
Copy link

@lukas-vlcek: This pull request references Bugzilla bug 1883719, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "4.7.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1883719: Bulk statistics are recorded under index threadpool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@blockloop
Copy link
Contributor

@lukas-vlcek did you run a cluster and verify the new queries?

@jcantrill
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 2, 2020
@openshift-ci-robot
Copy link

@jcantrill: This pull request references Bugzilla bug 1883719, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 2, 2020
@jcantrill
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 2, 2020
@lukas-vlcek
Copy link
Contributor Author

lukas-vlcek commented Oct 2, 2020

@blockloop

did you run a cluster and verify the new queries?

Not really, I had issues building EO image locally this week. But this is simple change I do not expect this should break anything even if the metric name is invalid.

@periklis
Copy link
Contributor

periklis commented Oct 2, 2020

/uncc @periklis

@openshift-ci-robot openshift-ci-robot removed the request for review from periklis October 2, 2020 15:00
@jcantrill
Copy link
Contributor

/retest

Copy link
Contributor

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I created a cluster and verified these metrics exist and the rules record

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, jcantrill, lukas-vlcek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dd4bfbd into openshift:master Oct 2, 2020
@openshift-ci-robot
Copy link

@lukas-vlcek: All pull requests linked via external trackers have merged:

Bugzilla bug 1883719 has been moved to the MODIFIED state.

In response to this:

Bug 1883719: Bulk statistics are recorded under index threadpool

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants