Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1906895: Fixing lost changes in 4.7 csv and adding 5.0 csv for disconnecting from ART #597

Merged
merged 1 commit into from Dec 14, 2020

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Dec 14, 2020

Description

This PR adds generated manifests for OpenShift Logging 5.0 to enable disconnect from ART. It keeps the 4.7 manifests in tact to enable E2E testing on upstream CI. Replaces #593 to fix YAML parse errors in building E2E olm registry.

time="2020-12-11T21:54:42Z" level=warning msg="permissive mode enabled" error="error loading manifests from directory: [could not decode contents of file /manifests/4.7/elasticsearch-operator.v4.7.0.clusterserviceversion.yaml into package: error converting YAML to JSON: yaml: line 274: could not find expected ':', could not decode contents of file /manifests/5.0/elasticsearch-operator.v5.0.0.clusterserviceversion.yaml into package: error converting YAML to JSON: yaml: line 274: could not find expected ':', error loading package into db: [FOREIGN KEY constraint failed, no default channel specified for elasticsearch-operator]]"

/cc @blockloop @vimalk78
/assign @jcantrill

Links

@periklis periklis changed the title bumping manifest version from 4.7 to 5.0 Bug 1906895: Fixing lost changes in 4.7 csv and adding 5.0 csv for disconnecting from ART Dec 14, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 14, 2020
@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1906895, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906895: Fixing lost changes in 4.7 csv and adding 5.0 csv for disconnecting from ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@periklis: This pull request references Bugzilla bug 1906895, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1906895: Fixing lost changes in 4.7 csv and adding 5.0 csv for disconnecting from ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@vimalk78 vimalk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2020
@jcantrill
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, periklis, vimalk78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 14, 2020
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

@openshift-merge-robot openshift-merge-robot merged commit a3cd3e3 into openshift:master Dec 14, 2020
@openshift-ci-robot
Copy link

@periklis: All pull requests linked via external trackers have merged:

Bugzilla bug 1906895 has been moved to the MODIFIED state.

In response to this:

Bug 1906895: Fixing lost changes in 4.7 csv and adding 5.0 csv for disconnecting from ART

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants