Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1910259: Fix missing grafana dashboard in OCP 4.7 #610

Conversation

huikang
Copy link
Contributor

@huikang huikang commented Jan 6, 2021

  • Fix cross-namespace owner reference for the configmap
  • Remove configmap after CR being deleted

Description

OCP 4.7 (k8s v1.20) does not allow cross-namespace owner reference. So the configmap is garbage collected due to invalid reference. This PR fixes the issue.

/cc @blockloop
/assign @ewolinetz

Links

- Fix cross-namespace owner reference for the configmap
- Remove configmap after CR being deleted
@openshift-ci-robot
Copy link

@huikang: This pull request references Bugzilla bug 1910259, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1910259: Fix missing grafana dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 6, 2021
@huikang huikang changed the title Bug 1910259: Fix missing grafana dashboard Bug 1910259: Fix missing grafana dashboard in OCP 4.7 Jan 6, 2021
@openshift-ci-robot
Copy link

@huikang: This pull request references Bugzilla bug 1910259, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.0) matches configured target release for branch (4.7.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1910259: Fix missing grafana dashboard in OCP 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huikang
Copy link
Contributor Author

huikang commented Jan 6, 2021

/retest

@ewolinetz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 6, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ewolinetz, huikang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 6, 2021
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@huikang
Copy link
Contributor Author

huikang commented Jan 7, 2021

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1bc3c55 into openshift:master Jan 8, 2021
@openshift-ci-robot
Copy link

@huikang: All pull requests linked via external trackers have merged:

Bugzilla bug 1910259 has been moved to the MODIFIED state.

In response to this:

Bug 1910259: Fix missing grafana dashboard in OCP 4.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huikang
Copy link
Contributor Author

huikang commented Jan 11, 2021

/cherry-pick release-4.6

@openshift-cherrypick-robot

@huikang: #610 failed to apply on top of branch "release-4.6":

Applying: Bug 1910259: Fix missing grafana dashboard
Using index info to reconstruct a base tree...
A	controllers/logging/elasticsearch_controller.go
A	internal/k8shandler/dashboards.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/k8shandler/dashboards.go
CONFLICT (content): Merge conflict in pkg/k8shandler/dashboards.go
CONFLICT (modify/delete): controllers/logging/elasticsearch_controller.go deleted in HEAD and modified in Bug 1910259: Fix missing grafana dashboard. Version Bug 1910259: Fix missing grafana dashboard of controllers/logging/elasticsearch_controller.go left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Bug 1910259: Fix missing grafana dashboard
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

huikang pushed a commit to huikang/elasticsearch-operator that referenced this pull request Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants