LOG-2308: Update createOrUpdate method for dashboard #851
Conversation
|
/retest |
There was a problem hiding this comment.
/hold Changing this delete/create to a createOrUpdate for dashboards neglects the fact that we cannot update across namespaces. The Elasticsearch CR is not the owner of that config-map leaving in openshift-config-managed. The safest way is to delete and re-create.
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/approve |
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: periklis, sasagarw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@sasagarw: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Description
This PR:
grafana-dashboard-elasticsearchis being created and deleted continously./cc @shwetaap
/assign @periklis
Links