Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOG-2693: Fix matching labels selectors for servicemonitors #894

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

periklis
Copy link
Contributor

@periklis periklis commented Jun 7, 2022

Description

This PR provides a fix that omits merging the Elasticsearch CR into the Elasticsearch ServiceMonitor labels selectors, e.g. the jaeger operator creates Elasticsearch CRs with custom labels (See jaeger-operator.

ServiceMonitor for ES via Jaeger CR showing up again:
image

/cc @Red-GV

/cherry-pick release-5.4

Links

@openshift-ci openshift-ci bot requested a review from Red-GV June 7, 2022 08:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2022

@periklis: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Red-GV
Copy link
Contributor

Red-GV commented Jun 7, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 7, 2022
@openshift-merge-robot openshift-merge-robot merged commit 4278ce1 into openshift:master Jun 7, 2022
@Red-GV
Copy link
Contributor

Red-GV commented Jun 7, 2022

/cherry-pick release-5.4

@openshift-cherrypick-robot

@Red-GV: new pull request created: #895

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants