-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update k8s to 0.26.2 and OpenShift to 4.13 #968
Update k8s to 0.26.2 and OpenShift to 4.13 #968
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to me, a couple of things though:
- What's about the Dockerfile's using go1.20? Follow-up PR?
- Doesn't the Makefile need for
operator-sdk run bundle
the new--security-context restricted
option to be set?
go.mod
Outdated
github.com/onsi/gomega v1.20.1 | ||
github.com/openshift/api v0.0.0-20220712151050-2647eb31dee7 // Corresponds to release-4.11 | ||
github.com/onsi/gomega v1.24.1 | ||
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.11 | |
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.13 |
/approve |
2e4fc93
to
6ba5579
Compare
Yes @periklis, I think we will need to wait for this PR (openshift/release#37343) and all the images to be published before updating the Dockerfile. So a follow up PR will be needed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: periklis, Red-GV The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This PR updates the k8s dependencies to v0.26.2 and OpenShift dependencies to 4.13.
/cc @xperimental
/assign @periklis