Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update k8s to 0.26.2 and OpenShift to 4.13 #968

Merged
merged 5 commits into from
Mar 15, 2023

Conversation

Red-GV
Copy link
Contributor

@Red-GV Red-GV commented Mar 14, 2023

This PR updates the k8s dependencies to v0.26.2 and OpenShift dependencies to 4.13.

/cc @xperimental
/assign @periklis

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
@openshift-ci openshift-ci bot requested a review from xperimental March 14, 2023 15:19
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Red-GV Red-GV marked this pull request as ready for review March 14, 2023 20:55
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 14, 2023
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me, a couple of things though:

  1. What's about the Dockerfile's using go1.20? Follow-up PR?
  2. Doesn't the Makefile need for operator-sdk run bundle the new --security-context restricted option to be set?

go.mod Outdated
github.com/onsi/gomega v1.20.1
github.com/openshift/api v0.0.0-20220712151050-2647eb31dee7 // Corresponds to release-4.11
github.com/onsi/gomega v1.24.1
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.11
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.11
github.com/openshift/api v0.0.0-20230228142948-d170fcdc0fa6 // Corresponds to release-4.13

@periklis
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 15, 2023
@Red-GV
Copy link
Contributor Author

Red-GV commented Mar 15, 2023

Yes @periklis, I think we will need to wait for this PR (openshift/release#37343) and all the images to be published before updating the Dockerfile. So a follow up PR will be needed.

@periklis
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 15, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: periklis, Red-GV

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2403ff1 and 2 for PR HEAD 6ba5579 in total

@Red-GV
Copy link
Contributor Author

Red-GV commented Mar 15, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 5bc42a6 into openshift:master Mar 15, 2023
@Red-GV Red-GV deleted the update-dependencies branch March 15, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants