Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golang version to 1.18 and k8s client to 1.24 #106

Merged
merged 1 commit into from Jul 20, 2022
Merged

Golang version to 1.18 and k8s client to 1.24 #106

merged 1 commit into from Jul 20, 2022

Conversation

aminesnow
Copy link
Contributor

Description

Update to use Go 1.18 and k8s client to 0.24.3.

/cc @periklis
/assign @periklis

Links

@openshift-ci openshift-ci bot requested a review from periklis July 20, 2022 15:21
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

periklis
periklis reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@periklis periklis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's put this in "ready for review" to let CI give it's testimonials.

@aminesnow aminesnow marked this pull request as ready for review July 20, 2022 17:26
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 20, 2022
@periklis
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aminesnow, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 20, 2022
@Red-GV
Copy link
Contributor

Red-GV commented Jul 20, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 20, 2022

@aminesnow: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Red-GV
Copy link
Contributor

Red-GV commented Jul 20, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 20, 2022
@openshift-merge-robot openshift-merge-robot merged commit e40f24b into openshift:master Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@periklis periklis periklis left review comments

Assignees

@periklis periklis

@Red-GV Red-GV

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aminesnow @periklis @Red-GV @openshift-merge-robot