Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add review guidelines from source google doc #49

Merged
merged 1 commit into from Sep 24, 2020
Merged

Add review guidelines from source google doc #49

merged 1 commit into from Sep 24, 2020

Conversation

periklis
Copy link
Contributor

This PR addresses a sync between our team's PR review guildelines from the original single source of truth in Google Docs back to the public repository.

/cc @ewolinetz @blockloop

@periklis
Copy link
Contributor Author

/retest

blockloop
blockloop approved these changes Sep 18, 2020
View reviewed changes
Copy link

@blockloop blockloop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2020
@jcantrill
Copy link
Contributor

/approve

@jcantrill jcantrill closed this Sep 24, 2020
@openshift-ci-robot
Copy link

@periklis: An error was encountered getting external tracker bugs for bug 0 on the Bugzilla server at https://bugzilla.redhat.com:

code 101: Bug #0 does not exist.
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Add review guidelines from source google doc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcantrill jcantrill reopened this Sep 24, 2020
@jcantrill
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: blockloop, jcantrill, periklis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit dd87dd4 into openshift:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blockloop blockloop blockloop approved these changes

@ewolinetz ewolinetz Awaiting requested review from ewolinetz

Assignees

@blockloop blockloop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@periklis @jcantrill @openshift-ci-robot @openshift-bot @blockloop @openshift-merge-robot