VDPA enhancement

[lmilleri]

This enhancement provides a proposal for integrating vDPA (Virtio Data Path Acceleration) in Openshift.

[openshift-ci]

Hi @lmilleri. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[zshi-redhat]

/ok-to-test

[lmilleri]

/cc @mandre @tjungblu @zshi-redhat @SchSeba @bn222

[dhellmann]

/test markdownlint

[dhellmann]

Those linter errors are real.

Summary: 17 error(s)
enhancements/vdpa/overview.md:26:401 MD013/line-length Line length [Expected: 400; Actual: 475]
enhancements/vdpa/overview.md:57:401 MD013/line-length Line length [Expected: 400; Actual: 540]
enhancements/vdpa/overview.md:63:401 MD013/line-length Line length [Expected: 400; Actual: 464]
enhancements/vdpa/overview.md:65:401 MD013/line-length Line length [Expected: 400; Actual: 599]
enhancements/vdpa/overview.md:71:401 MD013/line-length Line length [Expected: 400; Actual: 823]
enhancements/vdpa/vdpa-introduction.md:76:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:77:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:78:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:79:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:80:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:81:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:82:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:83:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:84:1 MD007/ul-indent Unordered list indentation [Expected: 0; Actual: 1]
enhancements/vdpa/vdpa-introduction.md:85:1 MD005/list-indent Inconsistent indentation for list items at the same level [Expected: 1; Actual: 0]
enhancements/vdpa/vdpa-introduction.md:86:1 MD005/list-indent Inconsistent indentation for list items at the same level [Expected: 1; Actual: 0]
enhancements/vdpa/vdpa-introduction.md:87:1 MD005/list-indent Inconsistent indentation for list items at the same level [Expected: 1; Actual: 0]

[lmilleri]

/test markdownlint

[lmilleri]

@dhellmann Can you please advise how to fix the remaining lint issues?

[dhellmann]

@dhellmann Can you please advise how to fix the remaining lint issues?

The issues are because of how the documents are structured. It looks like you're setting up vdpa as a new domain, which is fine. Within a domain there are some expectations about how the files are named so that the filename and title inside the document match.

For example, you could rename enhancements/vdpa/overview.md to enhancements/vdpa/vdpa-support overview.md and then set the title to VDPA Support Overview in the document and then rename enhancements/vdpa/vdpa-introduction.md to enhancements/vdpa/virtio-with-ovn-hw-offloading.md and change the title to Virtio with OVN HW offloading. Those are examples, you could use different names and titles if you prefer. But the filename and title need to match so that people who remember the title but not the URL can find the document through the GitHub UI.

The other errors about the tracking links are because the metadata for each enhancement needs to link to a Jira or Bugzilla ticket. See the top of the template file for the tracking-link field. I also see that you've added a status field to the header with provisional. We don't use that field any more for enhancements. Every enhancement needs to be linked to work we've committed to doing. Speculative proposals can be shared in other forms, including as PRs here marked WIP. See the top level readme in this repo for details. If you have a Jira ticket that's scheduled for work and tied to these documents, set the tracking-link and remove the status field and you'll be all set.

[zshi-redhat]

/lgtm

[zshi-redhat]

@lmilleri one more question: would it make sense to move the vdpa directory under enhancements/network?

[lmilleri]

@zshi-redhat moved vdpa to enhancements/network as suggested

[zshi-redhat]

/lgtm

[zshi-redhat]

@dcbw @dougbtv Could you review and approve if it looks good to you?

[wizhaoredhat]

/lgtm

[lmilleri]

@dcbw @dougbtv Could you please review and approve if it looks good to you?

[dougbtv]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• enhancements/network/OWNERS [dougbtv]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lmilleri: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.