installer-aws: create edge compute pool for AWS Local Zones #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
from
4d438fa
to
e46530d
Compare
mtulio
changed the title
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
from
e46530d
to
64ad757
Compare
mtulio
commented
Sep 15, 2022
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
from
6a6a3e9
to
84458cd
Compare
mtulio
commented
Sep 16, 2022
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/assign @patrickdillon @JoelSpeed @rvanderp3 @dhellmann |
4 tasks
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
2 times, most recently
from
8ca1a11
to
aa87fbb
Compare
jcpowermac
reviewed
Sep 23, 2022
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
jcpowermac
reviewed
Sep 23, 2022
There was a problem hiding this comment.
This is looking very good, thank you @mtulio! I left a few minor comments but in my opinion this is ready for review. @sdodson and @dhellmann might have opinions and of course our friends from installer @patrickdillon and @makentenza. Tks!
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
JoelSpeed
reviewed
Sep 26, 2022
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
mtulio
commented
Sep 27, 2022
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
from
16ff2e6
to
fdbdba4
Compare
mtulio
commented
Oct 7, 2022
There was a problem hiding this comment.
Review comments addressed to the document in my last commit. New topics have been added and/or updated:
- Motivation
- Proposal / Phase 1: subnet allocation, instance and volume type, MachineSets
- Infrastructure costs
- Risks
- Test plan (Need help!)
JoelSpeed
reviewed
Oct 19, 2022
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
enhancements/installer/aws-custom-edge-machineset-local-zones.md
Outdated
Show resolved
Hide resolved
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jun 13, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
|
Presubmits were also created for two phases, awaiting the final credentials for a CI Account: |
|
I'm happy to proceed, suggest to squash the commits before we merge though (you've tagged my GH in one, should remove that) |
The enhancement proposes to introduce a new compute pool type edge to create MachineSets on a day zero operations in IPI, deploying compute resources with `NoSchedule` taints in AWS Local Zones locations. The R&D is divided into three phases: - Phase 0 / SPLAT-635: Research options to create compute nodes on AWS Local Zones and document it as a day-0 - Phase 1 / SPLAT-636: Create edge compute pool to generate MachineSets for node with NoSchedule taints when installing a cluster in an existing VPC with AWS Local Zone subnets. - Phase 2 / SPLAT-657: Installer automates the network resources creation on Local Zone based on the edge compute pool. This EP covers Phases 1 and 2, as part of RFE-2782.
mtulio
force-pushed
the
aws-local-zone-edge-machineset
branch
from
c8b832e
to
15a2593
Compare
For sure, squashed! |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@mtulio: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jun 23, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 5, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 5, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 5, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 6, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 6, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 6, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 6, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 17, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 18, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 18, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 19, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 19, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
mtulio
added a commit
to mtulio/installer
that referenced
this pull request
Jul 20, 2023
Inserting the instructions to install a cluster expanding nodes in Local Zones (new VPC), into existing documentation of installing in existing VPC. The Day-2 section is also added for reference of existing Local Zone automation. The Day 2 is not part of the official documentation delivered on 4.14, but it is mapped as an open question in the enhancement proposal [1232](openshift/enhancements#1232). The steps described on the KCS was validated with QE and SDN teams.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The enhancement proposes to introduce a new compute pool type
edgeto create MachineSets on a day zero operations on IPI to deploy compute resources withNoScheduletaints in AWS Local Zones locations.The R&D is divided into three phases:
edgecompute pool to generate MachineSets for node withNoScheduletaints when installing a cluster in existing VPC with AWS Local Zone subnets.edgecompute pool.This EP covers Phases 1 and 2.
This EP is part of the RFE-2782.