Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics collection profiles #1298

Closed
wants to merge 26 commits into from
Closed

Metrics collection profiles #1298

wants to merge 26 commits into from

Commits on Dec 7, 2022

  1. Adds skeleton for monitoring/scrape-profiles

    @JoaoBraveCoding
    JoaoBraveCoding committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    edf8e8e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. monitoring/scrape-profiles-v1

    @JoaoBraveCoding
    JoaoBraveCoding committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e948486 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2022

  1. Re-writes some of the paragraphs, fixes typos and renames operational to 

    minimal
    @JoaoBraveCoding
    JoaoBraveCoding committed Dec 14, 2022
    Configuration menu
    Copy the full SHA
    f2e2dc5 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2023

  1. Added analysis to motivation, added more alternatives, added concrete 

    ServiceMonitor examples

Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
    @JoaoBraveCoding
    JoaoBraveCoding committed Jan 17, 2023
    Configuration menu
    Copy the full SHA
    061c590 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2023

  1. Apply Simon suggestions from code review 

    Co-authored-by: Simon Pasquier <spasquie@redhat.com>
    @JoaoBraveCoding @simonpasquier
    JoaoBraveCoding and simonpasquier committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    7d210b7 View commit details
    Browse the repository at this point in the history

  2. Addressed Simon review

    @JoaoBraveCoding
    JoaoBraveCoding committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    995f2de View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Adds reference to Hypershift implementation of scrape profiles 

    Signed-off-by: JoaoBraveCoding <jmarcal@redhat.com>
    @JoaoBraveCoding
    JoaoBraveCoding committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    719b231 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Pranshu Srivastava <prasriva@redhat.com>
    @JoaoBraveCoding @rexagod
    JoaoBraveCoding and rexagod committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    75f9e97 View commit details
    Browse the repository at this point in the history

  2. Renamed feature to metrics collection profiles

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    9451562 View commit details
    Browse the repository at this point in the history

  3. Address rexagod review comments

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    b961378 View commit details
    Browse the repository at this point in the history

  4. Fix some indentation

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    70da408 View commit details
    Browse the repository at this point in the history

  5. Commit Jan suggestion

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    61c414a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Addressed Jan review comments

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c3910ee View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Apply suggestions from code review 

    Co-authored-by: Pranshu Srivastava <prasriva@redhat.com>
    @JoaoBraveCoding @rexagod
    JoaoBraveCoding and rexagod committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    6b2963b View commit details
    Browse the repository at this point in the history

  2. Addressed Pranshu review comments

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b8ce949 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Address Pranshu review

    @JoaoBraveCoding
    JoaoBraveCoding committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    74e33fd View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Address Simon review comments

    @JoaoBraveCoding
    JoaoBraveCoding committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    650c20c View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @JoaoBraveCoding
    JoaoBraveCoding committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    7a07c6f View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. add documentation for CPV 

    added documentation for the CLI utility based on the recent discussion.

Signed-off-by: Pranshu Srivastava <rexagod@gmail.com>
    @rexagod
    rexagod committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    755ded3 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2023

  1. Update enhancements/monitoring/metrics-collection-profiles.md 

    Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
    @rexagod @JoaoBraveCoding
    rexagod and JoaoBraveCoding committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    cf7bedd View commit details
    Browse the repository at this point in the history

  2. Update enhancements/monitoring/metrics-collection-profiles.md 

    Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
    @rexagod @JoaoBraveCoding
    rexagod and JoaoBraveCoding committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    46aa3b9 View commit details
    Browse the repository at this point in the history

  3. Update enhancements/monitoring/metrics-collection-profiles.md 

    Co-authored-by: Joao Marcal <joao.marcal12@gmail.com>
    @rexagod @JoaoBraveCoding
    rexagod and JoaoBraveCoding committed Oct 16, 2023
    Configuration menu
    Copy the full SHA
    b8b25d4 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Merge pull request #1 from rexagod/scrape-profiles-post-cpv 

    add documentation for CPV
    @JoaoBraveCoding
    JoaoBraveCoding committed Oct 18, 2023
    Configuration menu
    Copy the full SHA
    7e37545 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2023

  1. Apply suggestions from juzhao code review 

    Co-authored-by: Junqi Zhao <juzhao@redhat.com>
    @JoaoBraveCoding @juzhao
    JoaoBraveCoding and juzhao committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f7694e7 View commit details
    Browse the repository at this point in the history

  2. Address some other review comments

    @JoaoBraveCoding
    JoaoBraveCoding committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    38f58d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Fixed markdown test

    @JoaoBraveCoding
    JoaoBraveCoding committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    48a5c98 View commit details
    Browse the repository at this point in the history