Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-319: Integrating MicroShift with Greenboot enhancement proposal #1306

Merged
merged 1 commit into from
Feb 3, 2023
Merged

USHIFT-319: Integrating MicroShift with Greenboot enhancement proposal #1306

merged 1 commit into from
Feb 3, 2023

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Dec 22, 2022 •
edited by openshift-ci bot

See USHIFT-319 for more information.

Closes: USHIFT-818

mangelajo
mangelajo suggested changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but looks good

enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
@ggiguash ggiguash force-pushed the microshift_greenboot branch 10 times, most recently from 85d870e to a99d3e2 Compare December 26, 2022 14:45
zshi-redhat
zshi-redhat reviewed Jan 3, 2023
View reviewed changes
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
@ggiguash ggiguash force-pushed the microshift_greenboot branch 3 times, most recently from 4a7ad37 to 72cb1f1 Compare January 3, 2023 09:23
oglok
oglok reviewed Jan 4, 2023
View reviewed changes
Copy link

@oglok oglok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well shaped. Thanks @ggiguash !

enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
dhellmann
dhellmann reviewed Jan 4, 2023
View reviewed changes
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Show resolved Hide resolved
enhancements/microshift/microshift-greenboot.md Outdated Show resolved Hide resolved
@ggiguash ggiguash force-pushed the microshift_greenboot branch 8 times, most recently from d58f00a to 0685932 Compare January 8, 2023 10:20
@ggiguash ggiguash force-pushed the microshift_greenboot branch 2 times, most recently from 8628d38 to b91d3c6 Compare January 19, 2023 16:12
@ggiguash ggiguash requested review from fzdarsky and removed request for dhellmann January 21, 2023 07:40
@ggiguash ggiguash requested review from dhellmann and fzdarsky and removed request for dhellmann and fzdarsky January 24, 2023 06:12
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-319 which is a valid jira issue.

In response to this:

See USHIFT-319 for more information.

Closes: USHIFT-818

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2023 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-319 which is a valid jira issue.

In response to this:

See USHIFT-319 for more information.

Closes: USHIFT-818

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 3, 2023

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d6db628 into openshift:master Feb 3, 2023
@dhellmann dhellmann removed the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oglok oglok oglok left review comments

@romfreiman romfreiman romfreiman left review comments

@zshi-redhat zshi-redhat zshi-redhat left review comments

@mangelajo mangelajo mangelajo requested changes

@fzdarsky fzdarsky fzdarsky requested changes

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@dhellmann dhellmann

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@ggiguash @dhellmann @openshift-ci-robot @mangelajo @oglok @romfreiman @zshi-redhat @fzdarsky @openshift-merge-robot