Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTA-787: enhancements/update/update-blocker-lifecycle: Port from Bugzilla to Jira #1323

Merged

Conversation

wking
Copy link
Member

@wking wking commented Jan 25, 2023

Brenton pointed out some workflow adjustments to make the component-team response more Jira-native, and this updates the enhancement to formalize those changes.

I'm still leaving the original labels on the bug ticket for now, until we figure out a way to port the Jira queue queries over to use only ticket status, but at the moment:

project != OCPBUGS AND labels in (UpgradeBlocker) AND status not in ("Code Review", ON_QA, Verified, "Release Pending", Done, Closed)

turns up things in private non-OpenShift-core projects that we'd need to filter out, so sticking with the OCPBUGS-side labels seems easier for now.

I've also left off the details of creating the component-team side ticket, where we currently want:

  • We create a Spike in the relevant component's Jira project (e.g. MCO-#). Let's use TEAM-# as a placeholder.
    1. Subject is: Impact ${BUG_SUBJECT}
    2. Assignee is the bug assignee.
    3. Body is our request template, but with OCPBUGS-# replaced with the actual bug.
    4. Priority is Critical, because it's hard to assess customer risk in the absence of an impact statement. If new information flows in that suggests further impact-statement work should be lower-priority for that bug, folks can reduce the priority later and explain their motivation.
    5. TEAM-# blocks OCPBUGS-#, because we should be able to get an initial draft at impact without waiting for the bug fix to merge, be verified, or ship.
    6. Label TEAM-# with UpgradeBlocker for tracking.
    7. Label OCPBUGS-# with ImpactStatementRequested to move it to the component-team queue.

Those seem like they can remain internal, mutable details for now, and not get frozen out in the enhancement yet.

Brenton pointed out some workflow adjustments to make the
component-team response more Jira-native [1], and this updates the
enhancement to formalize those changes.

I'm still leaving the original labels on the bug ticket for now, until
we figure out a way to port the Jira queue queries over to use only
ticket status, but at the moment:

  project != OCPBUGS AND labels in (UpgradeBlocker) AND status not in ("Code Review", ON_QA, Verified, "Release Pending", Done, Closed)

turns up things in private non-OpenShift-core projects that we'd need
to filter out, so sticking with the OCPBUGS-side labels seems easier
for now.

I've also left off the details of creating the component-team side
ticket, where we currently want:

  * We create a Spike in the relevant component's Jira project
    (e.g. MCO-#). Let's use TEAM-# as a placeholder.
    1. Subject is: Impact ${BUG_SUBJECT}
    2. Assignee is the bug assignee.
    3. Body is our request template, but with 'OCPBUGS-#' replaced with the actual bug.
    4. Priority is Critical, because it's hard to assess customer risk
       in the absence of an impact statement.  If new information
       flows in that suggests further impact-statement work should be
       lower-priority for that bug, folks can reduce the priority
       later and explain their motivation.
    5. TEAM-# blocks OCPBUGS-#, because we should be able to get an
       initial draft at impact without waiting for the bug fix to
       merge, be verified, or ship.
    6. Label TEAM-# with UpgradeBlocker for tracking.
    7. Label OCPBUGS-# with ImpactStatementRequested to move it to the
       component-team queue.

Those seem like they can remain internal, mutable details for now, and
not get frozen out in the enhancement yet.

[1]: https://issues.redhat.com/browse/OTA-787
@wking wking changed the title enhancements/update/update-blocker-lifecycle: Port from Bugzilla to Jira OTA-787: enhancements/update/update-blocker-lifecycle: Port from Bugzilla to Jira Jan 25, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2023

@wking: This pull request references OTA-787 which is a valid jira issue.

In response to this:

Brenton pointed out some workflow adjustments to make the component-team response more Jira-native, and this updates the enhancement to formalize those changes.

I'm still leaving the original labels on the bug ticket for now, until we figure out a way to port the Jira queue queries over to use only ticket status, but at the moment:

project != OCPBUGS AND labels in (UpgradeBlocker) AND status not in ("Code Review", ON_QA, Verified, "Release Pending", Done, Closed)

turns up things in private non-OpenShift-core projects that we'd need to filter out, so sticking with the OCPBUGS-side labels seems easier for now.

I've also left off the details of creating the component-team side ticket, where we currently want:

  • We create a Spike in the relevant component's Jira project (e.g. MCO-#). Let's use TEAM-# as a placeholder.
    1. Subject is: Impact ${BUG_SUBJECT}
    2. Assignee is the bug assignee.
    3. Body is our request template, but with OCPBUGS-# replaced with the actual bug.
    4. Priority is Critical, because it's hard to assess customer risk in the absence of an impact statement. If new information flows in that suggests further impact-statement work should be lower-priority for that bug, folks can reduce the priority later and explain their motivation.
    5. TEAM-# blocks OCPBUGS-#, because we should be able to get an initial draft at impact without waiting for the bug fix to merge, be verified, or ship.
    6. Label TEAM-# with UpgradeBlocker for tracking.
    7. Label OCPBUGS-# with ImpactStatementRequested to move it to the component-team queue.

Those seem like they can remain internal, mutable details for now, and not get frozen out in the enhancement yet.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@petr-muller
Copy link
Member

/cc

Copy link
Member

@petr-muller petr-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Holding for more 👀 if needed

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 27, 2023
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
Sample answers are provided to give more context and the ImpactStatementRequested label has been added to this bug.
When responding, please remove ImpactStatementRequested and set the ImpactStatementProposed label.
Sample answers are provided to give more context and the `ImpactStatementRequested` label has been added to OCPBUGS-#.
When responding, please move this ticket to `Code Review`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the separate Jira (spike) workflow anywhere in this PR. Do you want to add that in a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the only Jira-side action that the assignee needs to take, so I've included it here (replacing their previous Bugzilla-side action). From the PR topic post:

I've also left off the details of creating the component-team side ticket, where we currently want:
...
Those seem like they can remain internal, mutable details for now, and not get frozen out in the enhancement yet.

And yeah, that's all stuff on the updates-team/robots side that I didn't want to commit to in this pull request.

@LalatenduMohanty
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 27, 2023

@wking: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 5348c56 into openshift:master Jan 27, 2023
@wking wking deleted the jira-native-UpgradeBlocker-flow branch January 27, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants