Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-547: Propose host-based mirror for agent-based installer #1352

Closed
wants to merge 1 commit into from

Conversation

bfournie
Copy link

For disconnected installations with the agent-based installer, remove the need for an external mirror registry to provide the images as described in https://issues.redhat.com/browse/AGENT-262.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 16, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 16, 2023

@bfournie: This pull request references AGENT-547 which is a valid jira issue.

In response to this:

For disconnected installations with the agent-based installer, remove the need for an external mirror registry to provide the images as described in https://issues.redhat.com/browse/AGENT-262.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bfournie bfournie force-pushed the host-based-mirror branch 4 times, most recently from 14ca3ad to 5e6c66a Compare February 16, 2023 21:46
@bfournie
Copy link
Author

/cc @andfasano

enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@mhrivnak mhrivnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving this forward!

enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
enhancements/agent-installer/host-based-mirror.md Outdated Show resolved Hide resolved
For disconnected installations with the agent-based installer,
remove the need for an external mirror registry to provide the images
as described in https://issues.redhat.com/browse/AGENT-262.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 21, 2023

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2023
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2023
@openshift-bot
Copy link

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this May 4, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Contributor

@bfournie this design was closed by the bot without merging but I see the ticket it is linked to is marked in progress. Should this design be fixed up and merged?

@bfournie
Copy link
Author

@bfournie this design was closed by the bot without merging but I see the ticket it is linked to is marked in progress. Should this design be fixed up and merged?

Hi @dhellmann we won't be doing this work in the agent-based-installer to use a local registry. I will update https://issues.redhat.com/browse/AGENT-262. This work will now be done by the Ecosystem team as part of a different application.

@dhellmann
Copy link
Contributor

Sounds good, thanks @bfournie

@dhellmann
Copy link
Contributor

This pull request is closed with lifecycle/rotten. The associated Jira ticket, AGENT-262, has status "To Do". Should the PR be reopened, updated, and merged? If not, remove the lifecycle/rotten label to have this bot ignore it in the future.

@dhellmann dhellmann removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 18, 2023
@dhellmann
Copy link
Contributor

This pull request is closed with lifecycle/rotten. The associated Jira ticket, AGENT-262, has status "To Do". Should the PR be reopened, updated, and merged? If not, remove the lifecycle/rotten label to have this bot ignore it in the future.

I removed the stale label so you won't see these automated messages any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants