-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AGENT-547: Propose host-based mirror for agent-based installer #1352
Conversation
@bfournie: This pull request references AGENT-547 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
14ca3ad
to
5e6c66a
Compare
/cc @andfasano |
5e6c66a
to
4bc0f25
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving this forward!
4bc0f25
to
c8dff62
Compare
For disconnected installations with the agent-based installer, remove the need for an external mirror registry to provide the images as described in https://issues.redhat.com/browse/AGENT-262.
c8dff62
to
5cf34be
Compare
@bfournie: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@bfournie this design was closed by the bot without merging but I see the ticket it is linked to is marked in progress. Should this design be fixed up and merged? |
Hi @dhellmann we won't be doing this work in the agent-based-installer to use a local registry. I will update https://issues.redhat.com/browse/AGENT-262. This work will now be done by the Ecosystem team as part of a different application. |
Sounds good, thanks @bfournie |
This pull request is closed with lifecycle/rotten. The associated Jira ticket, AGENT-262, has status "To Do". Should the PR be reopened, updated, and merged? If not, remove the lifecycle/rotten label to have this bot ignore it in the future. |
I removed the stale label so you won't see these automated messages any more. |
For disconnected installations with the agent-based installer, remove the need for an external mirror registry to provide the images as described in https://issues.redhat.com/browse/AGENT-262.