Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOG-4606: Initial proposal for Azure Monitor Log integration #1497

Merged
merged 1 commit into from
Jan 17, 2024
Merged

LOG-4606: Initial proposal for Azure Monitor Log integration #1497

merged 1 commit into from
Jan 17, 2024

Conversation

vparfonov
Copy link
Contributor

@vparfonov vparfonov commented Oct 18, 2023 •
edited

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 18, 2023
@vparfonov vparfonov marked this pull request as ready for review October 19, 2023 12:14
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2023
@vparfonov vparfonov changed the title Initial proposal for Azure Monitor Log integration LOG-4606: Initial proposal for Azure Monitor Log integration Oct 19, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 19, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-4606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but it targets "Logging 5.9.0" instead.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 19, 2023 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-4606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.15.0" version, but it targets "Logging 5.9.0" instead.

In response to this:

ref: https://issues.redhat.com/browse/LOG-4606

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/cc @jcantrill @alanconway

jcantrill
jcantrill reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @alanconway

enhancements/cluster-logging/forward_to_azure_log_analytics.md Outdated Show resolved Hide resolved
enhancements/cluster-logging/forward_to_azure_log_analytics.md Outdated Show resolved Hide resolved
enhancements/cluster-logging/forward_to_azure_log_analytics.md Outdated Show resolved Hide resolved
@vparfonov vparfonov mentioned this pull request Oct 23, 2023
Merged
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 18, 2023
@vparfonov vparfonov force-pushed the log4606 branch 2 times, most recently from 2b4a680 to ed963b3 Compare November 21, 2023 13:26
@vparfonov
Copy link
Contributor Author

/remove-lifecycle stale

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2023
@openshift-bot
Copy link

Inactive enhancement proposals go stale after 28d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle stale.
Stale proposals rot after an additional 7d of inactivity and eventually close.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 27, 2023
@openshift-bot
Copy link

Stale enhancement proposals rot after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Rotten proposals close after an additional 7d of inactivity.
Exclude this proposal from closing by commenting /lifecycle frozen.

If this proposal is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2024
@openshift-bot
Copy link

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

@openshift-ci openshift-ci bot closed this Jan 11, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 11, 2024

@openshift-bot: Closed this PR.

In response to this:

Rotten enhancement proposals close after 7d of inactivity.

See https://github.com/openshift/enhancements#life-cycle for details.

Reopen the proposal by commenting /reopen.
Mark the proposal as fresh by commenting /remove-lifecycle rotten.
Exclude this proposal from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vparfonov
Copy link
Contributor Author

/reopen

@openshift-ci openshift-ci bot reopened this Jan 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@vparfonov: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 16, 2024 •
edited by openshift-ci bot

@vparfonov: This pull request references LOG-4606 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target either version "4.16." or "openshift-4.16.", but it targets "Logging 5.9.0" instead.

In response to this:

ref: https://issues.redhat.com/browse/LOG-4606

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vparfonov vparfonov force-pushed the log4606 branch 4 times, most recently from 21f09fa to d57d7ef Compare January 16, 2024 14:05
jcantrill
jcantrill approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

enhancements/cluster-logging/forward_to_azure_monitor_logs.md Outdated
//https://learn.microsoft.com/en-us/azure/azure-monitor/logs/data-collector-api?tabs=powershell#request-uri-parameters
CustomerId string `json:"customerId,omitempty"`

//LogType the record type of the data that is being submitted.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to mention this is distinct from "OpenShift Logging LogType" and essentially provides the tenent within context of the customer ID

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2024
alanconway
alanconway approved these changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@alanconway alanconway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanconway, jcantrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3ea5c01 and 2 for PR HEAD d57d7ef in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 16, 2024
@vparfonov vparfonov force-pushed the log4606 branch 3 times, most recently from a3472c9 to e09d266 Compare January 16, 2024 19:07
@vparfonov
LOG-4606: Initial proposal for Azure Monitor Log integration
5f1ea80 
Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2024

@vparfonov: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jcantrill
jcantrill reviewed Jan 17, 2024
View reviewed changes
Copy link
Contributor

@jcantrill jcantrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 17, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c433358 into openshift:master Jan 17, 2024
2 checks passed
@vparfonov vparfonov deleted the log4606 branch January 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcantrill jcantrill jcantrill approved these changes

@alanconway alanconway alanconway approved these changes

@periklis periklis Awaiting requested review from periklis

Assignees

@jcantrill jcantrill

@alanconway alanconway

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vparfonov @openshift-ci-robot @openshift-bot @jcantrill @alanconway