Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-4154:Add troubleshooting section for upgrades to OVN IC #1567

Merged

Conversation

ricky-rav
Copy link
Contributor

@ricky-rav ricky-rav commented Feb 19, 2024

  • Add section for troubleshooting upgrades to OVN-IC, now possible thanks to b9d6c0d
  • updated number of ovnkube-control-plane pods to 2, because of b5d5caf

@ricky-rav ricky-rav force-pushed the upgradeToICDocUpdate branch 2 times, most recently from b9d6c0d to 78ab723 Compare February 19, 2024 11:52
@ricky-rav ricky-rav changed the title Add troubleshooting section for upgrade to OVN IC Add troubleshooting section for upgrades to OVN IC Feb 19, 2024
@@ -101,6 +101,9 @@ data:
zone-mode: singlezone
temporary: true
```

The "temporary: true" field above is only used up until 4.14.13 and is omitted in later 4.14.z.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm should we stretch this a bit further and make it "omitted in releases >= 4.14.14 and >= 4.15 ?" I don't know if talking specifically about 4.14 z stream implies that 4.15 and other minor versions are not even effected by this..same comment here and elsewhere you mention versioning..
or maybe in context of upgrades 4.13 -> 4.15 will always go via 4.14 so we are ok here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only ever applies to upgrades to 4.14.z. There's no skipping releases when you upgrade :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: wanna change "last updated" ?

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@ricky-rav ricky-rav changed the title Add troubleshooting section for upgrades to OVN IC SDN-4154:Add troubleshooting section for upgrades to OVN IC Feb 20, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 20, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 20, 2024

@ricky-rav: This pull request references SDN-4154 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.14" instead.

In response to this:

  • Add section for troubleshooting upgrades to OVN-IC, now possible thanks to b9d6c0d
  • updated number of ovnkube-control-plane pods to 2, because of b5d5caf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@CFields651
Copy link

@ricky-rav the diagrams an doc are awesome! I think we could use a bit more explanation around "If ever a cluster is not making progress during the upgrade to OVN IC..." Like why would an upgrade not or stop making progress? What is lost by skipping phase 1 or phase 2; is there anything that needs to be cleaned up?

With openshift/cluster-network-operator#2076 we added the possibility to skip the 4.13->4.14 two-phase OVNK upgrade for toubleshooting purposes and fast forward to final YAMLs for 4.14 OVNK. Also, the ConfigMap pushed by CNO got simplified.

Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
@CFields651
Copy link

LGTM!

Copy link

@trozet trozet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

thanks @ricky-rav

@trozet
Copy link

trozet commented Mar 8, 2024

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 8, 2024
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
Copy link
Contributor

openshift-ci bot commented Mar 8, 2024

@ricky-rav: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c598849 into openshift:master Mar 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants