-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDN-4154:Add troubleshooting section for upgrades to OVN IC #1567
SDN-4154:Add troubleshooting section for upgrades to OVN IC #1567
Conversation
ricky-rav
commented
Feb 19, 2024
•
edited
edited
- Add section for troubleshooting upgrades to OVN-IC, now possible thanks to b9d6c0d
- updated number of ovnkube-control-plane pods to 2, because of b5d5caf
b9d6c0d
to
78ab723
Compare
@@ -101,6 +101,9 @@ data: | |||
zone-mode: singlezone | |||
temporary: true | |||
``` | |||
|
|||
The "temporary: true" field above is only used up until 4.14.13 and is omitted in later 4.14.z. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm should we stretch this a bit further and make it "omitted in releases >= 4.14.14 and >= 4.15 ?" I don't know if talking specifically about 4.14 z stream implies that 4.15 and other minor versions are not even effected by this..same comment here and elsewhere you mention versioning..
or maybe in context of upgrades 4.13 -> 4.15 will always go via 4.14 so we are ok here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It only ever applies to upgrades to 4.14.z. There's no skipping releases when you upgrade :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: wanna change "last updated" ?
Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
78ab723
to
f516a8b
Compare
@ricky-rav: This pull request references SDN-4154 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.16." or "openshift-4.16.", but it targets "openshift-4.14" instead. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@ricky-rav the diagrams an doc are awesome! I think we could use a bit more explanation around "If ever a cluster is not making progress during the upgrade to OVN IC..." Like why would an upgrade not or stop making progress? What is lost by skipping phase 1 or phase 2; is there anything that needs to be cleaned up? |
With openshift/cluster-network-operator#2076 we added the possibility to skip the 4.13->4.14 two-phase OVNK upgrade for toubleshooting purposes and fast forward to final YAMLs for 4.14 OVNK. Also, the ConfigMap pushed by CNO got simplified. Signed-off-by: Riccardo Ravaioli <rravaiol@redhat.com>
f516a8b
to
fb23c6d
Compare
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
thanks @ricky-rav
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ricky-rav: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |