Add enhancement for supporting user namespaces #1649
Conversation
|
/hold @deads2k is on vacation and should review this. I'm opening it for preliminary review though |
openshift-ci
bot
added
the
do-not-merge/hold
haircommander
force-pushed
the
scc-userns
branch
2 times, most recently
from
31705ee
to
55032bf
Compare
|
SCC piece openshift/api#1939 |
|
TPNU piece openshift/api#1940 |
openshift-ci
bot
removed
the
do-not-merge/hold
haircommander
force-pushed
the
scc-userns
branch
from
95cdfa8
to
3605bb1
Compare
| // +openshift:enable:FeatureGate=UserNamespacesSupport | ||
| // +kubebuilder:validation:Enum="Allowed";"Disallowed";"" | ||
| // +kubebuilder:validation:Optional | ||
| HostUsers HostUsersStrategyType `json:"hostUsers" protobuf:"varint,26,opt,name=allowHostUsers"` |
There was a problem hiding this comment.
Should this be AllowHostUsers? varint does not seem correct either. As does the "hostUsers" and "allowHostUsers" mismatch.
There was a problem hiding this comment.
good points, I must have done some weird copying
There was a problem hiding this comment.
The version there was suggested by me. We are discouraging the use of new booleans in APIs and, within OpenShift, even forbidding it. It's preferable to use enums since they can be expanded over time, where currently, these bool values will never be able to be expanded. The version here would adhere to current API guidelines, even though it creates a new pattern
haircommander
force-pushed
the
scc-userns
branch
from
3605bb1
to
edb1513
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
for API and auth team reviews |
|
New changes are detected. LGTM label has been removed. |
Signed-off-by: Peter Hunt <pehunt@redhat.com>
Signed-off-by: Peter Hunt <pehunt@redhat.com>
…pod SCC Signed-off-by: Peter Hunt <pehunt@redhat.com>
haircommander
force-pushed
the
scc-userns
branch
from
2dcdba1
to
4176f0e
Compare
|
@haircommander: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
related https://issues.redhat.com/browse/OCPNODE-2337
cc @rphillips @mrunalp