describe etcd 4.3 to 4.4 upgrade/downgrade #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
|
||
| 1. The 4.4-etcd-staticpod moves the /etcd/kubernetes/manifests/etcd-member.yaml to a backup location before trying to start etcd. | ||
| 2. This causes the 4.3-machineconfigpool to go degraded because the file that it tries to maintain is gone. | ||
| 3. If the master node restarts using a 4.3-machineconfigpool, the old /etcd/kubernetes/manifests/etcd-member.yaml will come back. |
There was a problem hiding this comment.
are you sure if MCD works that way. last i checked, if it sees user changed something it owns it just marks the node degraded. and doesn't so anything.
openshift-ci-robot
added
size/M
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, hexfusion The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves us in an interesting intermediate spot. We have a good story for the final upgrade/downgrade, but the intermediate state fails because we have a cluster-etcd-operator PR for step 1 and a machine-config-operator PR for step 4, but we cannot merge both at the same time.
Without the cluster-etcd-operator PR, the machine-config-operator PR won't install or upgrade because no etcd is present. Without the machine-config-operator PR, the cluster-etcd-operator PR cannot pass an upgrade because the machineconfigpool is permanently degraded.