Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: server/etcdmain: add configurable cipher list to gRPC proxy listener #139

Closed
wants to merge 2 commits into from

Conversation

dusk125
Copy link

@dusk125 dusk125 commented Aug 2, 2022

This will end up at upstream, but I want to test in Openshift before opening upstream.

@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

@dusk125: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

WIP: server/etcdmain: add configurable cipher list to gRPC proxy listener

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2022
@openshift-ci openshift-ci bot requested review from hasbro17 and wking August 2, 2022 19:29
@openshift-ci
Copy link

openshift-ci bot commented Aug 2, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2022
@dusk125
Copy link
Author

dusk125 commented Aug 3, 2022

Test procedure:

  1. oc get pods -n openshift-etcd
  2. Pick an etcd node
  3. oc exec -it -n openshift-etcd pod/<step-2-pod> -c etcd-metrics -- /bin/bash
  4. wget "https://github.com/drwetter/testssl.sh/releases/tag/v3.0.7" (or more recent version)
  5. tar -zxf <step-4-file>
  6. cd <step-5-dir>
  7. ./testssl.sh --sweet32 localhost:9979

You should see the following, not vulnerable is what we want.
Screenshot_20220803_121832

@openshift-ci
Copy link

openshift-ci bot commented Aug 3, 2022

@dusk125: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial 0948b56 link true /test e2e-aws-serial
ci/prow/configmap-scale 0948b56 link true /test configmap-scale

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dusk125 dusk125 closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants