New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-28736: Rebase etcd 3.5.12 openshift 4.12 #246
OCPBUGS-28736: Rebase etcd 3.5.12 openshift 4.12 #246
Conversation
Signed-off-by: Siyuan Zhang <sizhang@google.com>
[3.5] tests: Backport Extract e2e cluster setup to separate package
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Signed-off-by: Siyuan Zhang <sizhang@google.com>
[3.5] Backport e2e tests for livez/readyz.
…stent index and closing database on defer `err` variable shared throughout the NewServer function and used on line 396 to defer decision whether backend should be closed when starting the server failed. `snapshot` variable is first defined 407, redeclared locally on line 496 and later again used on line 625. Creation of local variable is a bug introduced in etcd-io#11888. Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
…coverSnapshotBackend on line 517 Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
[release-3.5] Fix etcd bootstrap: Etcd not validating database consistent index, closing database and panicking on nil backend.
Signed-off-by: ZhouJianMS <zhoujian@microsoft.com>
Signed-off-by: Amit Rastogi <amitrastogi2206@gmail.com>
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
[3.5] Add missing `experimental-enable-lease-checkpoint-persist` flag in etcd help
Backport testutils.ExecuteUntil to 3.5 branch
Signed-off-by: ishan16696 <ishan.tyagi@sap.com>
[3.5]Add a unit tests and missing flags in etcd help.
To ensure etcd official image builds can be reproduced. Signed-off-by: James Blair <mail@jamesblair.net>
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
[release-3.5] Don't flock snapshot files
…age-builds [3.5] Backport adding digest for etcd base image
[3.5] member replace e2e test
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Signed-off-by: Siyuan Zhang <sizhang@google.com>
[3.5] Fix delete inconsistencies in read buffer
Signed-off-by: Ivan Valdes <ivan@vald.es>
…0.13 [3.5] dependency: upgrade go to 1.20.13
…ompaction function Backporting commit 21bbc82 in etcd 3.5 To improve traceability of backend database usage, Added below parameter related to backend database usage metrics inside scheduledCompaction function. current-db-size-bytes current-db-size current-db-size-in-use-bytes current-db-size-in-use Signed-off-by: Rahul More <rahulbapumore@gmail.com>
[3.5] mvcc: Printing etcd backend database related metrics inside scheduleCompaction function
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
…240124 [3.5] Print error log when creating peer listener failed
Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@Elbehery: This pull request references Jira Issue OCPBUGS-28736, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Elbehery: This pull request references Jira Issue OCPBUGS-28736, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/payload 4.12 nightly informing |
/payload 4.12 nightly blocking |
@Elbehery: trigger 6 job(s) of type blocking for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/20c17b30-c058-11ee-8a5d-0568cf8f01cd-0 |
@Elbehery: trigger 54 job(s) of type informing for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/18540a80-c058-11ee-99f4-458d03028b58-0 |
/label cherry-pick-approved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #245 in, this is safe to land now.
/remove-label jira/invalid-bug
/label jira/valid-bug
/label backport-risk-assessed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Elbehery, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bb82e89
into
openshift:openshift-4.12
@Elbehery: Jira Issue OCPBUGS-28736: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-28736 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-etcd-container-v4.12.0-202403180808.p0.gbb82e89.assembly.stream.el8 for distgit ose-etcd. |
This PR rebases etcd 3.5.12 into openshift-4.12.
This PR has been created by this workflow
git rebase --rebase-merges --fork-point v3.5.11 v3.5.12
( rebasing the changes from upstream 3.5.11 --> 3.5.12 )After rebasing, running make locally produce