-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-91: document the domain name limitation #173
OCPBUGS-91: document the domain name limitation #173
Conversation
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8d27bf9
to
414f720
Compare
/jira refresh |
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @xenolinux |
414f720
to
0f7bb7a
Compare
I'm going to do the first pass review but will put a hold until someone from NetEdge can do the final review. |
/assign |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes to the documentation look straightforward to me and do a good job explaining the limitations. Nice job on the examples!
@candita from the NetEdge team will take a look next and pending approval will remove the hold.
/lgtm
0f7bb7a
to
1c4efdc
Compare
I like the changes to the format; that does make it a little clearer on where the limits apply. Readding lgtm. /lgtm |
/assign @xenolinux |
/assign @lihongan |
/check-required-labels |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, candita The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label px-approved |
/label qe-approved |
/bugzilla refresh The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity. |
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. Retaining the bugzilla/valid-bug label as it was manually added. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity. |
@openshift-bot: This pull request references Jira Issue OCPBUGS-91, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/jira refresh |
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/label docs-approved |
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@alebedev87: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-91 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds a README chapter to document the limitation on the length of the domain names managed by
ExternalDNS
instances.