Add cluster-federation CSV #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmorie The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
approved
pmorie
force-pushed
the
cluster-scoped
branch
from
317c349
to
b2b79f2
Compare
|
@pmorie I see this as the status on the |
pmorie
force-pushed
the
cluster-scoped
branch
from
8b28e51
to
55c66e4
Compare
|
/wip This is still wip, I'm working to debug it now. |
openshift-ci-robot
added
the
needs-rebase
openshift-ci-robot
removed
the
needs-rebase
|
/retest |
pmorie
force-pushed
the
cluster-scoped
branch
2 times, most recently
from
f87e945
to
efc0f14
Compare
pmorie
commented
Mar 4, 2019
| createdAt: "2019-01-01T00:00:00Z" | ||
| spec: | ||
| displayName: Cluster Federation | ||
| description: | |
There was a problem hiding this comment.
@robszumski can you help figure out how to meaningfully differentiate this from the other CSV?
openshift-ci-robot
added
size/XXL
|
/retest ...to pick up changes in #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
cluster-federationas a distinct CSV that supports a cluster-scoped deployment of federation in support of #29.cc @csrwng