Allow running under OLM's AllNamespaces install mode #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eventually, OLM will only use the AllNamespaces mode (watching all namespaces with WATCH_NAMESPACE="") for deploying. Because the operator is cluster-scoped and _not_ multi-tenant, we have to maintain the OwnNamespace/SingleNamespace mode even when using AllNamespaces.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@mrogers950: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
rhmdnd
reviewed
May 31, 2022
rhmdnd
reviewed
May 31, 2022
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the "de-scoping" changes that OLM will see. It means that eventually OLM will only install operators using the AllNamespaces installModeType, which sets WATCH_NAMESPACE to empty, and assumes that the operator will watch for objects in all namespaces. This PR enables AllNamespaces as a supported type, and forces to Own/SingleNamespace mode when running.
Note, forcing the OwnNamespace mode might seem like a hack, but we can't safely fully de-scope (switch to watching all namespaces) until OLM is able to restrict an operator to a single namespace through its new API (tentatively called "FeatureBinding"). Also, fully-descoping is only critical for operators that have dependencies, or depended on by operators with multiple installModes, or singleton operators that are multi-tenant aware.
Ref: https://issues.redhat.com/browse/OLM-1579
Ref: https://issues.redhat.com/browse/CMP-1355