Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-14348 Change the default config file to exclude kubelet CA #368

Merged
merged 1 commit into from May 31, 2023

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented May 30, 2023

We want to exclude the Kubelet CA file from the default config, so the user does not have to reinit the aide database when the cert gets renewed.

Link to the Jira Issue: OCPBUGS-14348

We want to exclude Kubelet CA file from the default config, so user does not have to reinit the aide databse when the cert gets renewed.
@openshift-ci openshift-ci bot requested review from jhrozek and rhmdnd May 30, 2023 05:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2023
@Vincent056
Copy link
Contributor Author

/retest

Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is causing issues, I don't see any other way
/lgtm

@jhrozek
Copy link
Contributor

jhrozek commented May 31, 2023

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 31, 2023

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Vincent056 Vincent056 changed the title Change the default config file to exclude kubelet CA OCPBUGS-14348 Change the default config file to exclude kubelet CA May 31, 2023
@Vincent056 Vincent056 added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 31, 2023
@Vincent056 Vincent056 merged commit af6e8f1 into openshift:master May 31, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants