-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMP-2175: Implement support for replaces attribute in CSV #525
base: master
Are you sure you want to change the base?
CMP-2175: Implement support for replaces attribute in CSV #525
Conversation
Doing this makes it so that OLM can build dependency graphs between operator versions, which make it easier for users perform installs on disconnected environments and upgrades.
@rhmdnd: This pull request references CMP-2175 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
.PHONY: set-current-version | ||
set-current-version: | ||
@echo "Using $(PREVIOUS_VERSION) as previous version" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This outputs the old version, but when the actual substitution takes place it puts the new version in. Need to investigate that.
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Doing this makes it so that OLM can build dependency graphs between
operator versions, which make it easier for users perform installs on
disconnected environments and upgrades.