Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMP-2175: Implement support for replaces attribute in CSV #525

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented May 10, 2024

Doing this makes it so that OLM can build dependency graphs between
operator versions, which make it easier for users perform installs on
disconnected environments and upgrades.

Doing this makes it so that OLM can build dependency graphs between
operator versions, which make it easier for users perform installs on
disconnected environments and upgrades.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 10, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 10, 2024

@rhmdnd: This pull request references CMP-2175 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Doing this makes it so that OLM can build dependency graphs between
operator versions, which make it easier for users perform installs on
disconnected environments and upgrades.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024

.PHONY: set-current-version
set-current-version:
@echo "Using $(PREVIOUS_VERSION) as previous version"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This outputs the old version, but when the actual substitution takes place it puts the new version in. Need to investigate that.

Copy link
Contributor

openshift-ci bot commented May 10, 2024

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-bundle-aws-upgrade 16478aa link true /test e2e-bundle-aws-upgrade
ci/prow/e2e-aws 16478aa link true /test e2e-aws
ci/prow/images 16478aa link true /test images
ci/prow/ci-index-file-integrity-operator-bundle 16478aa link true /test ci-index-file-integrity-operator-bundle
ci/prow/e2e-bundle-aws 16478aa link true /test e2e-bundle-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants