Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31257: Exclude additional files in default aide conf #534

Merged
merged 1 commit into from
May 30, 2024

Conversation

Vincent056
Copy link
Contributor

@Vincent056 Vincent056 commented May 29, 2024

We are going to exlucde following in the default aide conf:
!/hostroot/etc/cni/multus/certs for the OVN-Kubernetes CNI
!/hostroot/etc/kubernetes/compliance-operator for the Compliance Operator check runtime kubeletconfig !/hostroot/etc/kubernetes/node-feature-discovery for the Node Feature Discovery Operator

https://issues.redhat.com/browse/OCPBUGS-31257

We are going to exlucde following in the default aide conf:
!/hostroot/etc/cni/multus/certs for the OVN-Kubernetes CNI
!/hostroot/etc/kubernetes/compliance-operator for the Compliance Operator check runtime kubeletconfig
!/hostroot/etc/kubernetes/node-feature-discovery for the Node Feature Discovery Operator
@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 29, 2024
@openshift-ci-robot
Copy link

@Vincent056: This pull request references Jira Issue OCPBUGS-31257, which is invalid:

  • expected the bug to target the "4.17.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

We are going to exlucde following in the default aide conf:
!/hostroot/etc/cni/multus/certs for the OVN-Kubernetes CNI
!/hostroot/etc/kubernetes/compliance-operator for the Compliance Operator check runtime kubeletconfig !/hostroot/etc/kubernetes/node-feature-discovery for the Node Feature Discovery Operator

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Seems reasonable and existing e2e tests will verify the config works with AIDE.

It would be nice to have a separate set of situational tests that exercise the excluded config with the necessary operator, but that's a larger lift than what I think these e2e tests were intended for.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhmdnd
Copy link
Contributor

rhmdnd commented May 30, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 30, 2024
@openshift-ci-robot
Copy link

@rhmdnd: This pull request references Jira Issue OCPBUGS-31257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.17.0) matches configured target version for branch (4.17.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @xiaojiey

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from xiaojiey May 30, 2024 13:36
@openshift-merge-bot openshift-merge-bot bot merged commit 0c758a9 into openshift:master May 30, 2024
9 checks passed
@openshift-ci-robot
Copy link

@Vincent056: Jira Issue OCPBUGS-31257: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31257 has been moved to the MODIFIED state.

In response to this:

We are going to exlucde following in the default aide conf:
!/hostroot/etc/cni/multus/certs for the OVN-Kubernetes CNI
!/hostroot/etc/kubernetes/compliance-operator for the Compliance Operator check runtime kubeletconfig !/hostroot/etc/kubernetes/node-feature-discovery for the Node Feature Discovery Operator

https://issues.redhat.com/browse/OCPBUGS-31257

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants