-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31257: Exclude additional files in default aide conf #534
Conversation
We are going to exlucde following in the default aide conf: !/hostroot/etc/cni/multus/certs for the OVN-Kubernetes CNI !/hostroot/etc/kubernetes/compliance-operator for the Compliance Operator check runtime kubeletconfig !/hostroot/etc/kubernetes/node-feature-discovery for the Node Feature Discovery Operator
@Vincent056: This pull request references Jira Issue OCPBUGS-31257, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Vincent056: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Seems reasonable and existing e2e tests will verify the config works with AIDE.
It would be nice to have a separate set of situational tests that exercise the excluded config with the necessary operator, but that's a larger lift than what I think these e2e tests were intended for.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@rhmdnd: This pull request references Jira Issue OCPBUGS-31257, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@Vincent056: Jira Issue OCPBUGS-31257: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31257 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
We are going to exlucde following in the default aide conf:
!/hostroot/etc/cni/multus/certs
for the OVN-Kubernetes CNI!/hostroot/etc/kubernetes/compliance-operator
for the Compliance Operator check runtime kubeletconfig!/hostroot/etc/kubernetes/node-feature-discovery
for the Node Feature Discovery Operatorhttps://issues.redhat.com/browse/OCPBUGS-31257