Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1353: Add extra labels flag to controller #38

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

tsmetana
Copy link
Member

@tsmetana tsmetana commented Jun 7, 2023

Make use of the new flag added by openshift/gcp-filestore-csi-driver#17
The flag itself was copied from the GCP PD operator: https://github.com/openshift/gcp-pd-csi-driver-operator/blob/master/assets/controller.yaml#L53

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 7, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 7, 2023

@tsmetana: This pull request references STOR-1353 which is a valid jira issue.

In response to this:

Make use of the new flag added by openshift/gcp-filestore-csi-driver#17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2023
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane June 7, 2023 11:15
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 7, 2023
@tsmetana tsmetana changed the title WIP: STOR-1353: Add extra labels flag to controller STOR-1353: Add extra labels flag to controller Jun 8, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 8, 2023

@tsmetana: This pull request references STOR-1353 which is a valid jira issue.

In response to this:

Make use of the new flag added by openshift/gcp-filestore-csi-driver#17
The flag itself was copied from the GCP PD operator: https://github.com/openshift/gcp-pd-csi-driver-operator/blob/master/assets/controller.yaml#L53

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Jun 8, 2023

/retest
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2023
@openshift-merge-robot openshift-merge-robot merged commit f5d8b8c into openshift:main Jun 8, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants