New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1065: Rework sidecar bindings to bind common ClusterRoles #39
STOR-1065: Rework sidecar bindings to bind common ClusterRoles #39
Conversation
@mpatlasov: This pull request references STOR-1065 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpatlasov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5e1e676
to
f5bbc7b
Compare
PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, gcp-filestore csi driver operator may compose its sidecars ClusterRoles from those building blocks. This PR also moves permissions for `leases` resource from ClusterRole to per-namespace Role (`assets/rbac/lease_leader_election_role.yaml`).
f5bbc7b
to
9b4f640
Compare
/label docs-approved |
/retest |
1 similar comment
/retest |
/test operator-e2e |
/test operator-e2e-extended |
Currently this is blocker or unable to test as we can not provision volumes with gcp file store provisioner. |
/test operator-e2e |
2 similar comments
/test operator-e2e |
/test operator-e2e |
/test operator-e2e-extended |
|
/test operator-e2e |
|
/label qe-approved |
/test operator-e2e-extended |
/lgtm |
@mpatlasov: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, gcp-filestore csi driver operator may compose its sidecars ClusterRoles from those building blocks.
This PR also moves permissions for
leases
resource from ClusterRole to per-namespace Role (assets/rbac/lease_leader_election_role.yaml
).