Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1065: Rework sidecar bindings to bind common ClusterRoles #39

Conversation

mpatlasov
Copy link
Contributor

PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, gcp-filestore csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for leases resource from ClusterRole to per-namespace Role (assets/rbac/lease_leader_election_role.yaml).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 26, 2023

@mpatlasov: This pull request references STOR-1065 which is a valid jira issue.

In response to this:

PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, gcp-filestore csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for leases resource from ClusterRole to per-namespace Role (assets/rbac/lease_leader_election_role.yaml).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@mpatlasov mpatlasov force-pushed the Bind-sidecars-to-common-ClusterRoles branch from 5e1e676 to f5bbc7b Compare June 26, 2023 14:52
PR openshift/cluster-storage-operator#379 published builiding blocks of sidecar ClusterRoles. Now, gcp-filestore csi driver operator may compose its sidecars ClusterRoles from those building blocks.

This PR also moves permissions for `leases` resource from ClusterRole to per-namespace Role (`assets/rbac/lease_leader_election_role.yaml`).
@mpatlasov mpatlasov force-pushed the Bind-sidecars-to-common-ClusterRoles branch from f5bbc7b to 9b4f640 Compare June 26, 2023 20:31
@mpatlasov
Copy link
Contributor Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 29, 2023
@mpatlasov
Copy link
Contributor Author

/retest

1 similar comment
@ropatil010
Copy link

/retest

@mpatlasov
Copy link
Contributor Author

/test operator-e2e
/test operator-e2e-extended

@mpatlasov
Copy link
Contributor Author

/test operator-e2e-extended
/test operator-e2e

@ropatil010
Copy link

Currently this is blocker or unable to test as we can not provision volumes with gcp file store provisioner.
Error and Discussion have updated here STOR-1363

@mpatlasov
Copy link
Contributor Author

/test operator-e2e
/test operator-e2e-extended

2 similar comments
@mpatlasov
Copy link
Contributor Author

/test operator-e2e
/test operator-e2e-extended

@mpatlasov
Copy link
Contributor Author

/test operator-e2e
/test operator-e2e-extended

@mpatlasov
Copy link
Contributor Author

/test operator-e2e-extended
/test operator-e2e

@mpatlasov
Copy link
Contributor Author

ci/prow/operator-e2e-extended is perma failing, see #40.

@mpatlasov
Copy link
Contributor Author

/test operator-e2e

@mpatlasov
Copy link
Contributor Author

ci/prow/operator-e2e is perma failing, see #43

@ropatil010
Copy link

/label qe-approved
Test results updated here: STOR-1363

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 12, 2023
@mpatlasov
Copy link
Contributor Author

/test operator-e2e-extended
/test operator-e2e

@gnufied
Copy link
Member

gnufied commented Jul 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 19, 2023

@mpatlasov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/operator-e2e 9b4f640 link false /test operator-e2e
ci/prow/operator-e2e-extended 9b4f640 link false /test operator-e2e-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit c30df7b into openshift:main Jul 19, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants