Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-1688: Chore: add .snyk file to ignore false positives #70

Merged
merged 1 commit into from Dec 18, 2023
Merged

STOR-1688: Chore: add .snyk file to ignore false positives #70

merged 1 commit into from Dec 18, 2023

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Dec 13, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2023 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2023
@dobsonj
Copy link
Member Author

dobsonj commented Dec 13, 2023

/label px-approved
/label docs-approved
/label qe-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Dec 13, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 13, 2023 •
edited by openshift-ci bot

@dobsonj: This pull request references STOR-1688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

/test operator-e2e

@dobsonj
Copy link
Member Author

dobsonj commented Dec 14, 2023

/retest

@bertinatto
Copy link
Member

/retest-required

@dobsonj
Copy link
Member Author

dobsonj commented Dec 15, 2023

/retest

@mpatlasov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2023
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 91e15fe and 2 for PR HEAD 6e13647 in total

@bertinatto
Copy link
Member

/retest-required

1 similar comment
@bertinatto
Copy link
Member

/retest-required

@bertinatto
Copy link
Member

/retest

@bertinatto
Copy link
Member

The operator-e2e job seems broken, and his patch only adds a file used by the Snyk tool. It doesn't change any behavior in the operator. As a result, I'm overriding the job.

/override /ci/prow/operator-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@bertinatto: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /ci/prow/operator-e2e

Only the following failed contexts/checkruns were expected:

  • ci/prow/ci-index-gcp-filestore-csi-driver-operator-bundle
  • ci/prow/images
  • ci/prow/operator-e2e
  • ci/prow/operator-e2e-extended
  • ci/prow/unit
  • ci/prow/verify
  • ci/prow/verify-deps
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-ci-index-gcp-filestore-csi-driver-operator-bundle
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-images
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-operator-e2e
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-operator-e2e-extended
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-unit
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-verify
  • pull-ci-openshift-gcp-filestore-csi-driver-operator-main-verify-deps
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

The operator-e2e job seems broken, and his patch only adds a file used by the Snyk tool. It doesn't change any behavior in the operator. As a result, I'm overriding the job.

/override /ci/prow/operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bertinatto
Copy link
Member

The operator-e2e job seems broken, and his patch only adds a file used by the Snyk tool. It doesn't change any behavior in the operator. As a result, I'm overriding the job.

/override /ci/prow/operator-e2e

/override ci/prow/operator-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@bertinatto: Overrode contexts on behalf of bertinatto: ci/prow/operator-e2e

In response to this:

The operator-e2e job seems broken, and his patch only adds a file used by the Snyk tool. It doesn't change any behavior in the operator. As a result, I'm overriding the job.

/override /ci/prow/operator-e2e

/override ci/prow/operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Dec 18, 2023

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 1d3c3ce into openshift:main Dec 18, 2023
8 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-filestore-csi-driver-operator-container-v4.16.0-202312182358.p0.g1d3c3ce.assembly.stream for distgit ose-gcp-filestore-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@RomanBednar RomanBednar Awaiting requested review from RomanBednar

Assignees

@mpatlasov mpatlasov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dobsonj @openshift-ci-robot @bertinatto @mpatlasov @openshift-bot