Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29677: Add infrastructure annotations #83

Conversation

bertinatto
Copy link
Member

All required infrastructure-required annotations are added, plus the CSI one, which is optional.

CC @openshift/storage

All required infrastructure-required annotations are added, plus
the CSI one, which is optional.
@bertinatto
Copy link
Member Author

/jira cherrypick OCPBUGS-29072

Copy link
Contributor

openshift-ci bot commented Feb 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2024
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-29072 has been cloned as Jira Issue OCPBUGS-29677. Will retitle bug to link to clone.
/retitle OCPBUGS-29677: [release-4.15] Add infrastructure annotations

In response to this:

/jira cherrypick OCPBUGS-29072

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.15] Add infrastructure annotations OCPBUGS-29677: [release-4.15] Add infrastructure annotations Feb 19, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-29677, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

All required infrastructure-required annotations are added, plus the CSI one, which is optional.

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 19, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-29677, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29072 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29072 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto changed the title OCPBUGS-29677: [release-4.15] Add infrastructure annotations OCPBUGS-29677: Add infrastructure annotations Feb 19, 2024
@bertinatto
Copy link
Member Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 20, 2024
@duanwei33
Copy link

cc @ropatil010
(For labeling cherry-pick-approved, or performing pre-merge verification before labeling)

@ropatil010
Copy link

/test operator-e2e-extended

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 21, 2024
@chao007
Copy link
Contributor

chao007 commented Feb 21, 2024

Checked CI and it passed.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 21, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-29677, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29072 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29072 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

All required infrastructure-required annotations are added, plus the CSI one, which is optional.

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ropatil010
Copy link

/hold
Re-adding the comments with 4.15 cluster

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@chao007
Copy link
Contributor

chao007 commented Feb 22, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 22, 2024
@chao007
Copy link
Contributor

chao007 commented Feb 22, 2024

oc get pods/gcp-filestore-csi-driver-operator-66d67585b5-wf9gl -o json | grep image
                "image": "[quay.io/chao0070/gcp-filestore-csi-driver-operator](http://quay.io/chao0070/gcp-filestore-csi-driver-operator)",
                "imagePullPolicy": "IfNotPresent",
        "imagePullSecrets": [
                "image": "[quay.io/chao0070/gcp-filestore-csi-driver-operator:latest](http://quay.io/chao0070/gcp-filestore-csi-driver-operator:latest)",
                "imageID": "fb8b307bc6e874d8668d524db0de6a50bc4da22cf0ad2dd43e1e9a5d09010aff",

oc get pods/gcp-filestore-csi-driver-operator-66d67585b5-wf9gl -o json | grep features
            "[features.operators.openshift.io/csi](http://features.operators.openshift.io/csi)": "true",
            "[features.operators.openshift.io/disconnected](http://features.operators.openshift.io/disconnected)": "true",
            "[features.operators.openshift.io/fips-compliant](http://features.operators.openshift.io/fips-compliant)": "true",
            "[features.operators.openshift.io/proxy-aware](http://features.operators.openshift.io/proxy-aware)": "true",
            "[features.operators.openshift.io/tls-profiles](http://features.operators.openshift.io/tls-profiles)": "true",
            "[features.operators.openshift.io/token-auth-aws](http://features.operators.openshift.io/token-auth-aws)": "false",
            "[features.operators.openshift.io/token-auth-azure](http://features.operators.openshift.io/token-auth-azure)": "false",
            "[features.operators.openshift.io/token-auth-gcp](http://features.operators.openshift.io/token-auth-gcp)": "false",
            "[operators.openshift.io/infrastructure-features](http://operators.openshift.io/infrastructure-features)": "[\"csi\"]",

@jsafrane
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2024
@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 26, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit a923e95 into openshift:release-4.15 Feb 26, 2024
8 checks passed
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-29677: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29677 has been moved to the MODIFIED state.

In response to this:

All required infrastructure-required annotations are added, plus the CSI one, which is optional.

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-filestore-csi-driver-operator-container-v4.15.0-202402261508.p0.ga923e95.assembly.stream.el8 for distgit ose-gcp-filestore-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants