Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-29678: Remove TLS annotation in 4.14 #87

Merged
merged 1 commit into from
Mar 7, 2024
Merged

OCPBUGS-29678: Remove TLS annotation in 4.14 #87

merged 1 commit into from
Mar 7, 2024

Conversation

bertinatto
Copy link
Member

CC @openshift/storage

@bertinatto
Copy link
Member Author

/jira cherrypick OCPBUGS-29677

@openshift-ci-robot
Copy link

@bertinatto: Detected clone of Jira Issue OCPBUGS-29677 with correct target version. Will retitle the PR to link to the clone.
/retitle OCPBUGS-29678: Remove TLS annotation in 4.14

In response to this:

/jira cherrypick OCPBUGS-29677

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Remove TLS annotation in 4.14 OCPBUGS-29678: Remove TLS annotation in 4.14 Mar 1, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 1, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-29678, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from gnufied and tsmetana March 1, 2024 16:59
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@bertinatto
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 1, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-29678, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-29677 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-29677 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z
  • bug has dependents

Requesting review from QA contact:
/cc @chao007

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from chao007 March 1, 2024 17:06
@bertinatto
Copy link
Member Author

/test operator-e2e

@jsafrane
Copy link
Contributor

jsafrane commented Mar 4, 2024

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@jsafrane
Copy link
Contributor

jsafrane commented Mar 4, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Mar 4, 2024
@bertinatto
Copy link
Member Author

/test operator-e2e

@duanwei33
Copy link

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 6, 2024
@duanwei33
Copy link

ci/prow/operator-e2e-extended failed due to:
INFO[2024-03-01T17:10:12Z] Step operator-e2e-extended-ipi-install-install failed after 12s.

@duanwei33
Copy link

/test operator-e2e
/test operator-e2e-extended

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 790cd9b and 2 for PR HEAD 0e40a75 in total

@bertinatto
Copy link
Member Author

/test operator-e2e

@bertinatto
Copy link
Member Author

/hold
for test results from #63

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/test operator-e2e

1 similar comment
@bertinatto
Copy link
Member Author

/test operator-e2e

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 7, 2024

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bertinatto
Copy link
Member Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 5028f0a into openshift:release-4.14 Mar 7, 2024
8 checks passed
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-29678: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29678 has been moved to the MODIFIED state.

In response to this:

CC @openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-gcp-filestore-csi-driver-operator-container-v4.14.0-202403072110.p0.g5028f0a.assembly.stream.el8 for distgit ose-gcp-filestore-csi-driver-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@tsmetana tsmetana Awaiting requested review from tsmetana

@chao007 chao007 Awaiting requested review from chao007

Assignees

@jsafrane jsafrane

@chao007 chao007

@duanwei33 duanwei33

@ropatil010 ropatil010

@Phaow Phaow

@radeore radeore

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bertinatto @openshift-ci-robot @jsafrane @duanwei33 @openshift-bot @chao007 @ropatil010 @Phaow @radeore