Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE-878: Add userLabels in Infrastructure to driver args list #74

Merged
merged 2 commits into from Aug 15, 2023
Merged

CFE-878: Add userLabels in Infrastructure to driver args list #74

merged 2 commits into from Aug 15, 2023

Conversation

bharath-b-rh
Copy link
Contributor

PR has the changes for openshift/enhancements#1217 proposed to support GCP labels in OCP, which requires gcp-pd-csi-driver-operator to add gcp userLabels available in the status sub resource of infrastructure CR, to the gcp resources created by the driver.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 10, 2023 •
edited by openshift-ci bot

@bharath-b-rh: This pull request references CFE-878 which is a valid jira issue.

In response to this:

PR has the changes for openshift/enhancements#1217 proposed to support GCP labels in OCP, which requires gcp-pd-csi-driver-operator to add gcp userLabels available in the status sub resource of infrastructure CR, to the gcp resources created by the driver.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 10, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2023
@bharath-b-rh
Copy link
Contributor Author

/hold openshift/enhancements#1217

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2023
@jsafrane
Copy link
Contributor

/test test
/test verify

@bharath-b-rh
Copy link
Contributor Author

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2023
@bharath-b-rh
Copy link
Contributor Author

/cc @tsmetana

@bharath-b-rh bharath-b-rh marked this pull request as ready for review August 7, 2023 07:35
@openshift-ci openshift-ci bot requested a review from tsmetana August 7, 2023 07:35
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2023
@openshift-ci openshift-ci bot requested review from gnufied and jsafrane August 7, 2023 07:37
@bharath-b-rh
Copy link
Contributor Author

/retest

@bharath-b-rh
Copy link
Contributor Author

/test e2e-gcp

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

@bharath-b-rh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

tsmetana
tsmetana approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@tsmetana tsmetana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 9, 2023
@bharath-b-rh
Copy link
Contributor Author

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 9, 2023
@subhtk
Copy link

subhtk commented Aug 10, 2023 •
edited

/label docs-approved

@tsmetana
Copy link
Member

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-b-rh, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianli-wei
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 15, 2023
@bharath-b-rh
Copy link
Contributor Author

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Aug 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit 999fb4c into openshift:master Aug 15, 2023
9 checks passed
@bharath-b-rh bharath-b-rh deleted the cfe-878 branch August 15, 2023 12:55
@subhtk
Copy link

subhtk commented Aug 16, 2023

/label docs-approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmetana tsmetana tsmetana approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@tsmetana tsmetana

@subhtk subhtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bharath-b-rh @openshift-ci-robot @jsafrane @subhtk @tsmetana @jianli-wei @openshift-merge-robot