UPSTREAM: google/cadvisor: 2979: container/libcontainer: fix schedulerStatsFromProcs hogging memory and wrong stats #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing a few parameters, make this function a method, to simplify its calling as well as further development. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 2b607f0) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
The logic of the existing code of schedulerStatsFromProcs is to provide a cumulative stats for all the processes inside a container. Once the process is dead, its stat entry is no longer updated, but still used in totals calculation. This creates two problems: - pidsMetricsCache map is ever growing -- in case of many short-lived processes in containers this can impact kubelet memory usage a lot; - in case a new process with the same PID appears (as a result of PID reuse), the stats from the old one are overwritten, resulting in wrong totals (e.g. they can be less than previous, which should not ever be the case). To kill these two birds with one stone, let's accumulate stats from dead processes in pidsMetricsSaved, and remove them from the pidsMetricsCache. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 9a22e3e) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
/lgtm |
|
@rphillips: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@mrunalp: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
sjenning
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google#2979
xref: https://bugzilla.redhat.com/show_bug.cgi?id=2016175