enable hacbs by default

[abhinandan13jan]

Fixes

https://issues.redhat.com/browse/HAC-2492

Description

• set HACBS FLAG as true by default
• HACBS can be disabled by adding to url hacbs=false
• HACBS can be disabled by setting localstorage hacbs to true

Type of change

• Feature
• Bugfix
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Changes HACBS feature flag test

Browser conformance:

• Chrome
• Firefox
• Safari
• Edge

[christianvogt]

We just need to set the default value but still allow for overriding via url and local storage.

Suggested change

	export const IS_HACBS_DEFAULT = 'HACBS';
	export const enableHACBSFlagFromQueryParam = (setFlag: SetFeatureFlag): void => {
	if (IS_HACBS_DEFAULT) {
	setFlag(HACBS_FLAG, true);
	return;
	}
	let enabled = false;
	export const enableHACBSFlagFromQueryParam = (setFlag: SetFeatureFlag): void => {
	let enabled = true;

Further down we must also change how we read from localStorage:

    enabled = localStorage.getItem('hacbs') === 'true';

to:

    enabled = localStorage.getItem('hacbs') !== 'false';

[abhinandan13jan]

updated

[codecov]

Codecov Report

Merging #274 (588203e) into main (c3b321a) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #274   +/-   ##
=======================================
  Coverage   73.65%   73.65%           
=======================================
  Files         435      435           
  Lines        9182     9182           
  Branches     2455     2455           
=======================================
  Hits         6763     6763           
  Misses       2281     2281           
  Partials      138      138           

Impacted Files	Coverage Δ
src/hacbs/hacbsFeatureFlag.ts	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b321a...588203e. Read the comment docs.

[christianvogt]

@abhinandan13jan you'll need to update the cy tests because app-studio was the default.
Look for: localStorage.setItem('hacbs', 'true');

We'll need to set this to false for the app-studio tests for now.

[abhinandan13jan]

@christianvogt I've updated Integration tests but they are continuously Failing with ECON_RESET

[christianvogt]

@abhinandan13jan do they pass locally for you?

[christianvogt]

Need to update create-application-from-sample.spec.ts to disable the hacbs flag.

[christianvogt]

Likely don't need this anymore but do need to reload the non-hacbs tests.

[abhinandan13jan]

Updated

[abhinandan13jan]

the HACBS integration test runs fine for me. the hac-dev ones always times-out

[christianvogt]

/retest

[christianvogt]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, christianvogt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[abhinandan13jan]

/retest

[openshift-ci]

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.