Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dev tooling helper script to populate application lifecycle #278

Merged

Conversation

karthikjeeyar
Copy link
Contributor

@karthikjeeyar karthikjeeyar commented Dec 7, 2022

Fixes

https://issues.redhat.com/browse/HAC-2494

Description

Helper script will create all the custom resources need for the application lifecycle and expects the user to start the build pipeline by merging the PR.

List of resources created:

  1. Application
  2. Component
  3. Integration Tests (both in application and component context)
  4. Static environment
  5. Managed environment (ReleasePlan is created)

Note: Since appstudio staging user doesn't have enough permissions to create other resources in managed workspace (different ns) , some parts of the code is commented out. If a user has enough permission, then uncommenting the managed workspace resource creation will create entire release setup.

Type of change

  • Other (please describe):

Helper script to create a development/testing environment.

Screen shots / Gifs for design review

Screenshot 2022-12-07 at 5 25 38 PM

workflow-graph.mov

How to test or reproduce?

Added Readme:

Description

This script helps to setup a development environment for an entire application lifecycle.

Prerequisites

  1. Install the appstudio-staging-ci Github app in your github
  2. Copy the content from template.env file and create a new .env file and add your values.

Setup

  1. Run the setup script from your root directory and pass your github repository to build.
    helpers/setup.sh https://github.com/your_username_/Project-Name.git
  2. Once the setup is complete, merge your new PR in your repository to trigger a new build pipeline.

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

cc: @christianvogt

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #278 (7784af1) into main (1966729) will increase coverage by 0.03%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
+ Coverage   73.61%   73.65%   +0.03%     
==========================================
  Files         433      435       +2     
  Lines        9123     9182      +59     
  Branches     2438     2455      +17     
==========================================
+ Hits         6716     6763      +47     
- Misses       2269     2281      +12     
  Partials      138      138              
Impacted Files Coverage Δ
...nts/IntegrationTest/IntegrationTestDetailsView.tsx 82.35% <0.00%> (ø)
...ipelineRunDetailsView/PipelineRunVisualization.tsx 100.00% <0.00%> (ø)
...elineRunDetailsView/tabs/PipelineRunDetailsTab.tsx 100.00% <0.00%> (ø)
...s/overview/visualization/hooks/useAppBuildNodes.ts 100.00% <0.00%> (ø)
...overview/visualization/hooks/useAppWorkflowData.ts 100.00% <0.00%> (ø)
...rview/visualization/hooks/useAppComponentsNodes.ts 100.00% <0.00%> (ø)
...w/visualization/hooks/useAppApplictionTestNodes.ts 100.00% <0.00%> (ø)
...isualization/hooks/useAppStaticEnvironmentNodes.ts 100.00% <0.00%> (ø)
.../components/topology/factories/GraphErrorState.tsx 88.00% <0.00%> (ø)
src/pages/RedirectPage.tsx 0.00% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1966729...7784af1. Read the comment docs.

Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the scripts, working fine. Just had a question

helpers/resources/release/bootstrap.sh Outdated Show resolved Hide resolved
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022

@karthikjeeyar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@rottencandy rottencandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2022
@christianvogt
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 9, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, karthikjeeyar, rottencandy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2022
@openshift-merge-robot openshift-merge-robot merged commit 5a13d22 into openshift:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants