create component with git context and revision #326
Conversation
openshift-ci
bot
added
the
approved
christianvogt
force-pushed
the
git-options
branch
from
b591663
to
83d061f
Compare
|
Hey, I've merged the PR that fixed the e2e tests - #305. So going forward it would be good to run the e2e tests locally and paste the screenshot here on the PR before merging. Can you do that? |
christianvogt
force-pushed
the
git-options
branch
2 times, most recently
from
0658be0
to
d0973d7
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #326 +/- ##
==========================================
+ Coverage 75.07% 75.09% +0.02%
==========================================
Files 432 432
Lines 9170 9150 -20
Branches 2483 2470 -13
==========================================
- Hits 6884 6871 -13
+ Misses 2162 2156 -6
+ Partials 124 123 -1
Continue to review full report at Codecov.
|
christianvogt
force-pushed
the
git-options
branch
from
d0973d7
to
fe477bd
Compare
|
|
||
| setFieldValue('source', sourceUrl); | ||
| setFieldValue('source.git.url', newSourceUrl); |
There was a problem hiding this comment.
Sample validation schema needs to be updated as well.
christianvogt
force-pushed
the
git-options
branch
from
fe477bd
to
dbeb294
Compare
|
Private git source is always failing right now |
|
@christianvogt: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, rottencandy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes
https://issues.redhat.com/browse/HAC-2743
Description
Git reference (as revision) and context were not set for CDQ and component creation
Type of change
How to test or reproduce?
Create a monorepo such that a git context can be provided and also ensure there is a valid branch on the repo to test with.
When creating a component, set the git reference and context appropriately.
Create the component.
Note that due to a bug in HAS, the revision is not returned in the component stub response of CDQ. As such the Component is still missing the revision at creation time. This should get resolved when the HAS bug is addressed
Browser conformance: