Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ComponentRelation): use component from all applications #909

Merged

Conversation

sahil143
Copy link
Contributor

@sahil143 sahil143 commented Mar 4, 2024

Fixes

https://issues.redhat.com/browse/HAC-5657

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

image

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 87.80488% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 85.87%. Comparing base (440184a) to head (a58d847).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #909      +/-   ##
==========================================
- Coverage   85.95%   85.87%   -0.09%     
==========================================
  Files         613      613              
  Lines       15773    15796      +23     
  Branches     4460     4469       +9     
==========================================
+ Hits        13558    13565       +7     
- Misses       2075     2090      +15     
- Partials      140      141       +1     
Files Coverage Δ
...onents/ComponentRelation/ComponentRelationForm.tsx 100.00% <100.00%> (ø)
src/components/ComponentRelation/cr-modals.tsx 90.90% <ø> (-6.07%) ⬇️
src/components/ComponentRelation/useNudgeData.ts 95.00% <100.00%> (+0.26%) ⬆️
...mponentRelation/ComponentRelationshipDropdowns.tsx 83.60% <93.75%> (+0.84%) ⬆️
...nents/ComponentRelation/ComponentRelationModal.tsx 66.66% <81.81%> (-15.48%) ⬇️
src/hooks/useComponents.ts 70.21% <75.00%> (+0.98%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440184a...a58d847. Read the comment docs.

Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

@sahil143: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@karthikjeeyar
Copy link
Contributor

Tested locally

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2024
Copy link
Contributor

openshift-ci bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: karthikjeeyar, sahil143

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 881d7fb into openshift:main Mar 6, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants