feat(release): trigger release form #911

abhinandan13jan · 2024-03-08T14:36:57Z

Fixes

https://issues.redhat.com/browse/HAC-5665
https://issues.redhat.com/browse/HAC-5666
https://issues.redhat.com/browse/HAC-5667

Description

Trigger release base form + add a bug Modal

![ezgif com-resize](https://github.com/openshift/hac-dev/assets/24852534/7794c429-7c2a-4d96-8067-7a6f13300291)

Type of change

Screen shots / Gifs for design review

How to test or reproduce?

Create a release Plan oc apply -f releasePlan.yaml

apiVersion: appstudio.redhat.com/v1alpha1
kind: ReleasePlan
metadata:
 labels:
   release.appstudio.openshift.io/auto-release: 'true'
 name: sre-production 
 namespace: abhindas-tenant 
spec:
 application: devfile-sample
 target: managed-workspace

Go to Releases from sideNav -> ReleasePlan List -> Trigger Release plan action
Fill up the form and open Network Tab.
Check that the Release object is created successfully

Browser conformance:

Chrome
Firefox
Safari
Edge

codecov · 2024-03-12T23:11:55Z

Codecov Report

Attention: Patch coverage is 85.90604% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 85.88%. Comparing base (440184a) to head (46254c2).
Report is 9 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #911      +/-   ##
==========================================
- Coverage   85.95%   85.88%   -0.07%     
==========================================
  Files         613      627      +14     
  Lines       15773    16135     +362     
  Branches     4460     4550      +90     
==========================================
+ Hits        13558    13858     +300     
- Misses       2075     2136      +61     
- Partials      140      141       +1

Files	Coverage Δ
...rc/components/ImportForm/utils/validation-utils.ts	`100.00% <100.00%> (ø)`
.../TriggerRelease/AddIssueSection/ComponentField.tsx	`100.00% <100.00%> (ø)`
.../TriggerRelease/AddIssueSection/StatusDropdown.tsx	`100.00% <100.00%> (ø)`
...ReleasePlan/TriggerRelease/ReleasePlanDropdown.tsx	`100.00% <100.00%> (ø)`
...ce/ReleasePlan/TriggerRelease/SnapshotDropdown.tsx	`100.00% <100.00%> (ø)`
.../ReleasePlan/TriggerRelease/TriggerReleaseForm.tsx	`100.00% <100.00%> (ø)`
...ReleaseService/ReleasePlan/releaseplan-actions.tsx	`92.30% <100.00%> (+0.64%)`	⬆️
...ared/components/empty-state/FilteredEmptyState.tsx	`100.00% <100.00%> (ø)`
src/types/coreBuildService.ts	`100.00% <ø> (ø)`
...Plan/TriggerRelease/AddIssueSection/UploadDate.tsx	`88.88% <88.88%> (ø)`
... and 7 more

... and 20 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 440184a...46254c2. Read the comment docs.

sahil143 · 2024-03-13T08:49:01Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/AddIssueModal.tsx

+}) => {
+  const [isModalOpen, setIsModalOpen] = React.useState(false);
+  const [isTimePickerOpen, setIsTimePickerOpen] = React.useState(false);
+  const dateRef = React.useRef(null);


Where is this dataRef being used?

sahil143 · 2024-03-13T08:51:15Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/AddIssueModal.tsx

+    if (dateRef && dateRef.current && dateRef.current.isCalendarOpen) {
+      dateRef.current.toggleCalendar(false, event.key);
+    } else if (isTimePickerOpen) {
+      setIsTimePickerOpen(false);


dataRef and isTimePickerOpen are not being used anywhere

sahil143 · 2024-03-13T08:57:40Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/AddIssueSection.tsx

+              <Table
+                aria-label="Simple table"
+                variant="compact"
+                borders
+                className="pf-v5-u-m-0 pf-v5-u-p-0"
+              >


Why not use the Table component that we use everywhere in list pages?

FieldArray, arrayHelper & index doesn't work properly with our ../shared/Table, using standard patternfly table

sahil143 · 2024-03-13T09:13:48Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/BugFormContent.tsx

+
+  return (
+    <Form>
+      <div ref={formRef}>


formRef not being used anywhere

sahil143 · 2024-03-13T09:15:13Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/BugFormContent.tsx

+                e.preventDefault(), handleSubmit();
+                modalToggle();


e.preventDefault();
handleSubmit();
modalToggle();

sahil143 · 2024-03-13T09:19:21Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/ComponentField.tsx

+
+  return (
+    <FieldArray
+      name="components"


this value should be the name coming from props

sahil143 · 2024-03-13T09:35:32Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/TriggerReleaseFormPage.tsx

+      // edit
+      //   ? await editReleasePlan(releasePlan, values, workspace, true)
+      //   : await createReleasePlan(values, namespace, workspace, true);


remove these comments

sahil143 · 2024-03-13T09:41:10Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/form-utils.ts

+      releasePlan: rp,
+      snapshot,
+      data: {
+        advisory: {


this should be releaseNotes

sahil143 · 2024-03-13T09:42:28Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/form-utils.ts

+          cves,
+          issues,


talk to errata team to figure out if bugs/cves should be under references

no update yet from errata team. I am using fields as per the latest conversation. I see the object is being created with the correct values in releaseNotes.
Maybe the errata team should remap the values in their API end or file a bug with all the changes they request as there is no document/link provided thus far

sahil143 · 2024-03-13T09:43:20Z

src/types/coreBuildService.ts

 };

 export type ReleaseSpec = {
  snapshot: string;
  releasePlan: string;
+  data?: {
+    advisory?: {


change advisory to releaseNotes

sahil143 · 2024-03-13T10:19:23Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/form-utils.ts

+    releasePlan: rp,
+    snapshot,
+    cves,
+    topic,
+    labels: labelPairs,
+    description,
+    solution,
+    issues,
+    synopsis,


reference field is there in form but not used here

sahil143 · 2024-03-18T07:11:46Z

@abhinandan13jan Everything looks good! Just one small change required. Please add - in table if a field value is not present

karthikjeeyar · 2024-03-18T09:02:17Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/StatusDropdown.tsx

+  { key: 'inProgress', value: 'In progress' },
+  { key: 'closed', value: 'Closed' },
+  { key: 'resolved', value: 'Resolved' },


This shows the status of the bug: Resolved, Unresolved.

As per Design docs, its Resolved or Unresolved but currently I see the below options, was this changed later on ? If yes then closed and resolved seems confusing.

karthikjeeyar · 2024-03-18T09:10:59Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/AddIssueSection.tsx

+                            isBug ? issueTableColumnClass.bugUrl : issueTableColumnClass.bugUrl
+                          }
+                        >
+                          <Truncate content={issue.url} />


URL field accepts any random text, shouldn't we add url validation while adding a bug fix info ?

karthikjeeyar · 2024-03-18T09:18:21Z

src/components/ReleaseService/ReleasePlan/TriggerRelease/AddIssueSection/BugFormContent.tsx

+        <StackItem>
+          <InputField data-test="bug-url" label="URL" name="url" required />
+        </StackItem>
+        <StackItem>


Date picker field is missing "Last updated" title.

karthikjeeyar · 2024-03-18T09:35:59Z

src/components/ReleaseService/ReleasePlan/releaseplan-actions.tsx

+      id: `trigger-releaseplan-${obj.metadata.name}`,
+      cta: {
+        href: `/application-pipeline/release/workspaces/${workspace}/release-plan/trigger`,
+      },


Can we add access check review to see if the user has access to create a release, if not disable the action with tooltip ?

karthikjeeyar · 2024-03-18T09:37:10Z

src/pages/TriggerReleasePlanPage.tsx

+
+const TriggerReleasePlanPage: React.FC<React.PropsWithChildren<unknown>> = () => {
+  const accessReviewResources: AccessReviewResources = [
+    { model: ReleasePlanModel, verb: 'create' },


Shouldn't this be ReleaseModel?

Suggested change

{ model: ReleasePlanModel, verb: 'create' },

{ model: ReleaseModel, verb: 'create' },

abhinandan13jan · 2024-03-18T12:44:04Z

@sahil143 @karthikjeeyar updated

karthikjeeyar

/approve

openshift-ci · 2024-03-18T12:51:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinandan13jan, karthikjeeyar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [karthikjeeyar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sahil143 · 2024-03-18T14:15:41Z

/lgtm

sahil143 · 2024-03-18T14:15:59Z

/retest

abhinandan13jan · 2024-03-18T14:26:06Z

/retest

openshift-ci · 2024-03-18T14:42:46Z

@abhinandan13jan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 8, 2024

feat(release): trigger release plan

d0f1c31

abhinandan13jan force-pushed the trigger-release-form branch from 28b7d37 to d0f1c31 Compare March 8, 2024 14:38

openshift-ci bot requested review from jrichter1 and karthikjeeyar March 8, 2024 14:38

feat(release): add bug to release

22428e7

abhinandan13jan changed the title ~~[WIP] Trigger release form~~ feat(release): trigger release form Mar 12, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024

feat(releases): bugs

fb85c3d

abhinandan13jan force-pushed the trigger-release-form branch from 886e304 to fb85c3d Compare March 12, 2024 13:11

abhinandan13jan changed the title ~~feat(release): trigger release form~~ [WIP]feat(release): trigger release form Mar 12, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024

abhinandan13jan force-pushed the trigger-release-form branch from ca9d62b to 977babd Compare March 12, 2024 22:49

abhinandan13jan changed the title ~~[WIP]feat(release): trigger release form~~ feat(release): trigger release form Mar 12, 2024

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024

sahil143 suggested changes Mar 13, 2024

View reviewed changes

openshift-ci bot assigned sahil143 Mar 13, 2024

sahil143 reviewed Mar 13, 2024

View reviewed changes

abhinandan13jan force-pushed the trigger-release-form branch from 977babd to 1cdd0be Compare March 13, 2024 13:02

abhinandan13jan requested a review from sahil143 March 13, 2024 14:58

abhinandan13jan force-pushed the trigger-release-form branch 9 times, most recently from 9befd3e to 5ad87eb Compare March 14, 2024 14:03

abhinandan13jan force-pushed the trigger-release-form branch from 5ad87eb to 6c80f09 Compare March 14, 2024 16:45

karthikjeeyar reviewed Mar 18, 2024

View reviewed changes

abhinandan13jan force-pushed the trigger-release-form branch from 6c80f09 to 8194ec0 Compare March 18, 2024 09:57

feat(releases): add cve

46254c2

abhinandan13jan force-pushed the trigger-release-form branch from 8194ec0 to 46254c2 Compare March 18, 2024 12:34

abhinandan13jan requested a review from karthikjeeyar March 18, 2024 12:35

karthikjeeyar approved these changes Mar 18, 2024

View reviewed changes

openshift-ci bot assigned karthikjeeyar Mar 18, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2024

rohitkrai03 merged commit cc55262 into openshift:main Mar 18, 2024
5 of 7 checks passed

rohitkrai03 mentioned this pull request Jun 3, 2024

chore(main): release rhtap-ui 0.5.0 #938

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(release): trigger release form #911

feat(release): trigger release form #911

abhinandan13jan commented Mar 8, 2024 •

edited

codecov bot commented Mar 12, 2024 •

edited

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

abhinandan13jan Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

abhinandan13jan Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 Mar 13, 2024

sahil143 commented Mar 18, 2024 •

edited

karthikjeeyar Mar 18, 2024

karthikjeeyar Mar 18, 2024

karthikjeeyar Mar 18, 2024

karthikjeeyar Mar 18, 2024

karthikjeeyar Mar 18, 2024

abhinandan13jan commented Mar 18, 2024

karthikjeeyar left a comment

openshift-ci bot commented Mar 18, 2024

sahil143 commented Mar 18, 2024

sahil143 commented Mar 18, 2024

abhinandan13jan commented Mar 18, 2024

openshift-ci bot commented Mar 18, 2024

	{ model: ReleasePlanModel, verb: 'create' },
	{ model: ReleaseModel, verb: 'create' },

feat(release): trigger release form #911

feat(release): trigger release form #911

Conversation

abhinandan13jan commented Mar 8, 2024 • edited

Fixes

Description

Type of change

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

codecov bot commented Mar 12, 2024 • edited

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sahil143 commented Mar 18, 2024 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abhinandan13jan commented Mar 18, 2024

karthikjeeyar left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Mar 18, 2024

sahil143 commented Mar 18, 2024

sahil143 commented Mar 18, 2024

abhinandan13jan commented Mar 18, 2024

openshift-ci bot commented Mar 18, 2024

abhinandan13jan commented Mar 8, 2024 •

edited

codecov bot commented Mar 12, 2024 •

edited

sahil143 commented Mar 18, 2024 •

edited